OCM-8337 | fix: [HCP] always set replicas when updating machinepools #2124
Conversation
|
@chenz4027 PTAL, as linked with #1940 |
We always pass the replicas when editing a machinepool, even if the value has not changed, as this will then be a no-op. Right now we are not setting replicas if they are the same as the current value and this result in an error returned to the user. Related: OCM-8337
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2124 +/- ##
==========================================
+ Coverage 26.65% 26.67% +0.02%
==========================================
Files 152 152
Lines 21402 21403 +1
==========================================
+ Hits 5705 5710 +5
+ Misses 15273 15269 -4
Partials 424 424 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreadecorte, chenz4027, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreadecorte, chenz4027, robpblake The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@andreadecorte: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We always pass the replicas when editing a machinepool, even if the value has not changed, as this will then be a no-op. Right now we are not setting replicas if they are the same as the current value and this result in an error returned to the user.
Related: OCM-8337