Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM-5186 | fix: align nodepool actions with machinepools #1940

Merged
merged 1 commit into from
Apr 19, 2024
Merged

OCM-5186 | fix: align nodepool actions with machinepools #1940

merged 1 commit into from
Apr 19, 2024

Conversation

chenz4027
Copy link
Contributor

@codecov Codecov
Copy link

codecov bot commented Apr 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 23.76238% with 77 lines in your changes are missing coverage. Please review.

Project coverage is 22.43%. Comparing base (5af070a) to head (d876b18).
Report is 18 commits behind head on master.

Files Patch % Lines
cmd/edit/machinepool/nodepool.go 24.48% 37 Missing ⚠️
cmd/edit/machinepool/machinepool.go 26.08% 34 Missing ⚠️
cmd/edit/machinepool/cmd.go 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1940      +/-   ##
==========================================
+ Coverage   21.69%   22.43%   +0.73%     
==========================================
  Files         118      129      +11     
  Lines       19804    20550     +746     
==========================================
+ Hits         4297     4610     +313     
- Misses      15186    15592     +406     
- Partials      321      348      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenz4027 chenz4027 force-pushed the OCM-5186 branch 2 times, most recently from 663d685 to 56d1555 Compare April 17, 2024 19:03
@chenz4027
OCM-5186 | fix: align nodepool actions with machinepools
d876b18 
Signed-off-by: Maggie Chen <[email protected]>

refactor

Signed-off-by: Maggie Chen <[email protected]>

change for machinepool

Signed-off-by: Maggie Chen <[email protected]>

add test coverage

Signed-off-by: Maggie Chen <[email protected]>

refactor

Signed-off-by: Maggie Chen <[email protected]>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

@chenz4027: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

robpblake
robpblake approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@robpblake robpblake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, robpblake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 58d0250 into openshift:master Apr 19, 2024
9 checks passed
@chenz4027 chenz4027 deleted the OCM-5186 branch May 9, 2024 14:52
@andreadecorte andreadecorte mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robpblake robpblake robpblake approved these changes

@oriAdler oriAdler Awaiting requested review from oriAdler

@willkutler willkutler Awaiting requested review from willkutler

Assignees

@robpblake robpblake

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenz4027 @robpblake