OCPBUGS-34918: Use build_root image from repository for coredns-ocp-dnsnamresolver #52809
Conversation
openshift-ci-robot
added
jira/severity-moderate
|
@arkadeepsen: This pull request references Jira Issue OCPBUGS-34918, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
openshift-ci
bot
added
the
approved
|
/pj-rehearse auto-ack |
|
@arkadeepsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
arkadeepsen
force-pushed
the
golang-bump-coredns-ocp-dnsnamresolver
branch
from
2935f97 to
539e67e
Compare
|
/pj-rehearse auto-ack |
|
@arkadeepsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
arkadeepsen
force-pushed
the
golang-bump-coredns-ocp-dnsnamresolver
branch
from
539e67e to
ccee906
Compare
|
/pj-rehearse auto-ack |
|
@arkadeepsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
arkadeepsen
force-pushed
the
golang-bump-coredns-ocp-dnsnamresolver
branch
from
ccee906 to
d43890e
Compare
|
/pj-rehearse |
|
@arkadeepsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
openshift/coredns-ocp-dnsnameresolver#9 should fix the issue of |
|
/assign @alebedev87 |
|
/retest |
|
/jira refresh |
openshift-ci-robot
added
jira/severity-critical
|
@Miciah: This pull request references Jira Issue OCPBUGS-34918, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -7,7 +7,7 @@ build_root: | |||
| image_stream_tag: | |||
| name: release | |||
| namespace: openshift | |||
| tag: golang-1.21 | |||
| tag: rhel-9-release-golang-1.22-openshift-4.17 | |||
There was a problem hiding this comment.
I think that we can set up the build_root from the repository like it's done in CoreDNS. This would simplify the ci config and move the version update to the repository where this decision is taken.
arkadeepsen
force-pushed
the
golang-bump-coredns-ocp-dnsnamresolver
branch
from
d43890e to
e7812a5
Compare
arkadeepsen
changed the title
|
@arkadeepsen: This pull request references Jira Issue OCPBUGS-34918, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@arkadeepsen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
arkadeepsen
force-pushed
the
golang-bump-coredns-ocp-dnsnamresolver
branch
from
e7812a5 to
90292d4
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
Adding the label as the rehearse won't pass on the main branch. openshift/coredns-ocp-dnsnameresolver#9 adds the necessary changes. /pj-rehearse ack |
|
@arkadeepsen: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, arkadeepsen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@arkadeepsen: Jira Issue OCPBUGS-34918: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-34918 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This PR uses build_root image from repository for coredns-ocp-dnsnamresolver.