-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-34918: Bump go version to 1.22 and fix issue with go install #9
Conversation
@arkadeepsen: This pull request references Jira Issue OCPBUGS-34918, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
However, this PR needs to be merged for the pj-rehearse to pass for |
/assign @alebedev87 |
@arkadeepsen: This pull request references Jira Issue OCPBUGS-34918, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test all |
operator/Makefile
Outdated
@@ -180,7 +180,7 @@ define go-install-tool | |||
set -e; \ | |||
package=$(2)@$(3) ;\ | |||
echo "Downloading $${package}" ;\ | |||
GOBIN=$(LOCALBIN) go install $${package} ;\ | |||
GOFLAGS='' GOBIN=$(LOCALBIN) go install $${package} ;\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this solve the problem without overriding all the go flags?
GOFLAGS='' GOBIN=$(LOCALBIN) go install $${package} ;\ | |
GOBIN=$(LOCALBIN) go install -mod=mod $${package} ;\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using -mod=mod
also worked.
@arkadeepsen: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@arkadeepsen: Jira Issue OCPBUGS-34918: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-34918 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This PR updates the Makefile of DNSNameResolver operator to fix the issue with go install by using
-mod=mod
. The go version of the ocp_dnsnameresolver plugin is also bumped to 1.22 and local CI config for build_root image is added.