Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-34918: Bump go version to 1.22 and fix issue with go install #9

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

arkadeepsen
Copy link
Member

@arkadeepsen arkadeepsen commented Jun 5, 2024

This PR updates the Makefile of DNSNameResolver operator to fix the issue with go install by using -mod=mod. The go version of the ocp_dnsnameresolver plugin is also bumped to 1.22 and local CI config for build_root image is added.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 5, 2024
@openshift-ci-robot
Copy link

@arkadeepsen: This pull request references Jira Issue OCPBUGS-34918, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR updates the Makefile to fix the issue with go install by using GOFLAGS=''.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from lihongan, gcs278 and rfredette June 5, 2024 11:36
@arkadeepsen
Copy link
Member Author

ci/prow/build is failing because the CI config uses golang-1.21 for the build_root image. openshift/release#52809 updates the CI config to use golang-1.22. The pj-rehearse passed for ci/prow/build in the openshift/release PR using the golang-1.22 image tag.

However, this PR needs to be merged for the pj-rehearse to pass for ci/prow/build-operator and ci/prow/unit-operator in openshift/release#52809.

@candita
Copy link

candita commented Jun 5, 2024

/assign @alebedev87

@arkadeepsen arkadeepsen changed the title OCPBUGS-34918: Update Makefile to fix issue with go install by using GOFLAGS='' OCPBUGS-34918: Bump go version to 1.22 and fix issue with go install Jun 7, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. and removed jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. labels Jun 7, 2024
@openshift-ci-robot
Copy link

@arkadeepsen: This pull request references Jira Issue OCPBUGS-34918, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR updates the Makefile of DNSNameResolver operator to fix the issue with go install by using GOFLAGS=''. The go version of the ocp_dnsnameresolver plugin is also bumped to 1.22 and local CI config for build_root image is added.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@arkadeepsen
Copy link
Member Author

/test all

@@ -180,7 +180,7 @@ define go-install-tool
set -e; \
package=$(2)@$(3) ;\
echo "Downloading $${package}" ;\
GOBIN=$(LOCALBIN) go install $${package} ;\
GOFLAGS='' GOBIN=$(LOCALBIN) go install $${package} ;\
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this solve the problem without overriding all the go flags?

Suggested change
GOFLAGS='' GOBIN=$(LOCALBIN) go install $${package} ;\
GOBIN=$(LOCALBIN) go install -mod=mod $${package} ;\

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using -mod=mod also worked.

Copy link

openshift-ci bot commented Jun 7, 2024

@arkadeepsen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alebedev87
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
Copy link

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d81eecb into openshift:main Jun 10, 2024
7 checks passed
@openshift-ci-robot
Copy link

@arkadeepsen: Jira Issue OCPBUGS-34918: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34918 has been moved to the MODIFIED state.

In response to this:

This PR updates the Makefile of DNSNameResolver operator to fix the issue with go install by using -mod=mod. The go version of the ocp_dnsnameresolver plugin is also bumped to 1.22 and local CI config for build_root image is added.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants