Enable Network Selection in ROSA #44633
Conversation
This PR will allow users to choose between OpenshiftSDN/ OVNKubernetes, always defaults to OVNKubernetes Signed-off-by: Krishna Harsha Voora <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/pj-rehearse pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.13-nightly-x86-perfscale-rosa-multiaz-control-plane-3nodes |
|
/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.14-nightly-x86-perfscale-rosa-multiaz-control-plane-24nodes-periodic |
|
/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.12-nightly-x86-perfscale-rosa-multiaz-control-plane-24nodes-periodic |
Signed-off-by: Krishna Harsha Voora <[email protected]>
|
/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.15-nightly-x86-perfscale-rosa-multiaz-control-plane-24nodes-periodic |
|
@krishvoor: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
The recent failure is not related to the PR in itself, but due to a Known bug, tracked via https://issues.redhat.com/browse/OCM-4433 |
krishvoor
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/assign @jtaleric |
|
There is a PR already in review for blocker bug, hoping that it will be merged soon so we can successfully run rehearsals before merging. |
|
Since the PR is now merged, running the rehearse |
|
/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.15-nightly-x86-perfscale-rosa-multiaz-control-plane-24nodes-periodic |
|
The job here 4.15 CP Job has passed while passing OpenShiftSDN as network type. From the scope of this PR, I'll revert 4.15 CP Job to normal |
|
@svetsa-rh - I have updated my commit, this is now good to merge |
|
/pj-rehearse ack |
openshift-ci-robot
added
the
rehearsals-ack
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
Harsha, from the log I see that it is an OVN cluster while it looks like you were expecting to test SDN. "network": { |
|
Also, my suggestion is to add a new test(s) to this same PR to add SDN so it's easy to rehearse than reverting changes. |
I am not sure ah, further investigation https://github.com/openshift/rosa/blob/master/cmd/create/cluster/cmd.go#L540-L547 https://github.com/openshift/rosa/blob/master/pkg/ocm/clusters.go#L45 Maybe this is a bug against ROSA cli? |
More information in this doc
Looks like this will not be a supported option from 4.15 GA onwards, so the code changes might be aligned for the same. |
openshift-ci-robot
removed
the
rehearsals-ack
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: krishvoor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
A total of 110 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.12-nightly-x86-perfscale-rosa-multiaz-control-plane-24nodes-periodic |
I suspect this |
|
Based on conversation, we will be switching to Self-Managed AWS and make use of this option: |
This PR will allow users to choose between OpenshiftSDN/ OVNKubernetes, always defaults to OVNKubernetes