Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERFSCALE-2349]: Loaded Migration - OpenShift SDN to OVNK #42306

Closed
wants to merge 10 commits into from
Closed

[PERFSCALE-2349]: Loaded Migration - OpenShift SDN to OVNK #42306

wants to merge 10 commits into from

Conversation

krishvoor
Copy link
Member

@krishvoor krishvoor commented Aug 14, 2023 •
edited
Loading

This PR allows users to run the "load" on the OCP via OpenShift SDN
and eventually, move OVNK, allowing users to understand what potentially issues might can get uncovered.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2023
@openshift-ci-robot
Copy link
Contributor

@krishvoor, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase repo client
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from qiliRedHat and svetsa-rh August 14, 2023 14:45
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 14, 2023
@krishvoor krishvoor changed the title Loaded Migration for AWS Loaded Migration: OpenShift SDN to OVNK Aug 14, 2023
@svetsa-rh
Copy link
Member

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.13-ocp-qe-perfscale-aws-sdn-to-ovn-120nodes-periodic

@svetsa-rh
Copy link
Member

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.13-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.12-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-ocp-qe-perfscale-aws-data-path-9nodes-periodic

svetsa-rh
svetsa-rh reviewed Aug 14, 2023
View reviewed changes
...r/jobs/openshift-qe/ocp-qe-perfscale-ci/openshift-qe-ocp-qe-perfscale-ci-main-periodics.yaml Outdated
ci.openshift.io/generator: prowgen
job-release: "4.12"
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.12-ocp-qe-perfscale-aws-sdn-to-ovn-120nodes-periodic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishvoor Can we add slack notifications for all the new tests you have added? You need to update this periodics yaml file and add it below name and above spec.
Here is an example https://github.com/svetsa-rh/release/blob/master/ci-operator/jobs/openshift-qe/ocp-qe-perfscale-ci/openshift-qe-ocp-qe-perfscale-ci-main-periodics.yaml#L20

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svetsa-rh : sure will add them

@krishvoor
Copy link
Member Author

/retest

@krishvoor
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic

@svetsa-rh
Copy link
Member

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.12-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.13-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic

@jtaleric
Copy link
Contributor

Any reason to have an explicit timeout here

+ oc wait mcp --all --for=condition=UPDATING=True --timeout=300s
timed out waiting for the condition on machineconfigpools/master
timed out waiting for the condition on machineconfigpools/worker

We could just use the CI system timeout instead of the 300?

@jtaleric
Copy link
Contributor

https://github.com/openshift/release/blob/master/ci-operator/step-registry/ovn/sdn-migration/ovn-sdn-migration-commands.sh#L33

We might need to get with the OVN team to make these timeouts vars instead of statically set.

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 19, 2023
@krishvoor
Copy link
Member Author

Any reason to have an explicit timeout here

+ oc wait mcp --all --for=condition=UPDATING=True --timeout=300s
timed out waiting for the condition on machineconfigpools/master
timed out waiting for the condition on machineconfigpools/worker

We could just use the CI system timeout instead of the 300?

These were the defaults, will update the logic, incase timeout is not set, will default to 300

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2023
@vishnuchalla vishnuchalla mentioned this pull request Aug 23, 2023
Closed
@vishnuchalla
Copy link
Contributor

vishnuchalla commented Aug 23, 2023 •
edited
Loading

Any reason to have an explicit timeout here

+ oc wait mcp --all --for=condition=UPDATING=True --timeout=300s
timed out waiting for the condition on machineconfigpools/master
timed out waiting for the condition on machineconfigpools/worker

We could just use the CI system timeout instead of the 300?

These were the defaults, will update the logic, incase timeout is not set, will default to 300

Fix PR: #42672

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2023
@vishnuchalla vishnuchalla mentioned this pull request Aug 24, 2023
Merged
@krishvoor krishvoor changed the title Loaded Migration: OpenShift SDN to OVNK [PERFSCALE-2394]: Loaded Migration: OpenShift SDN to OVNK Sep 20, 2023
@krishvoor krishvoor changed the title [PERFSCALE-2394]: Loaded Migration: OpenShift SDN to OVNK [PERFSCALE-2394]: Loaded Migration - OpenShift SDN to OVNK Sep 20, 2023
@krishvoor krishvoor changed the title [PERFSCALE-2394]: Loaded Migration - OpenShift SDN to OVNK [PERFSCALE-2349]: Loaded Migration - OpenShift SDN to OVNK Sep 20, 2023
@krishvoor krishvoor closed this Sep 20, 2023
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 20, 2023
@krishvoor
Refactor'd on the most recent changes
ab82341 
Signed-off-by: Krishna Harsha Voora <[email protected]>
@krishvoor krishvoor reopened this Sep 20, 2023
@openshift-ci-robot
Copy link
Contributor

@krishvoor: job(s): periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.12-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic either don't exist or were not found to be affected, and cannot be rehearsed

@krishvoor
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-perfscale-aws-sdn-to-ovn-24nodes-periodic

@jtaleric
Copy link
Contributor

It doesn't appear you are taking advantage of the timeout param that @vishnuchalla added?

https://github.com/openshift/release/blob/master/ci-operator/step-registry/ovn/sdn-migration/ovn-sdn-migration-ref.yaml#L9

@krishvoor
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.12-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic

@krishvoor
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-perfscale-aws-sdn-to-ovn-24nodes-periodic

@openshift-ci-robot
Copy link
Contributor

@krishvoor: job(s): periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.12-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic either don't exist or were not found to be affected, and cannot be rehearsed

@krishvoor
Copy link
Member Author

Recent failure from this URL is not related to the PR in itself, however, due to a test failure, will retrigger the job.

@krishvoor
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-perfscale-aws-sdn-to-ovn-24nodes-periodic

@krishvoor
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-perfscale-aws-sdn-to-ovn-24nodes-periodic

@krishvoor
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic

@openshift-ci-robot
Copy link
Contributor

@krishvoor: job(s): periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic either don't exist or were not found to be affected, and cannot be rehearsed

@krishvoor
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.12-nightly-x86-perfscale-rosa-sdn-to-ovn-24nodes-periodic

@krishvoor
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-perfscale-aws-sdn-to-ovn-24nodes-periodic

@krishvoor
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.12-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic

@openshift-ci-robot
Copy link
Contributor

@krishvoor: job(s): periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.12-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic either don't exist or were not found to be affected, and cannot be rehearsed

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@krishvoor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.12-nightly-x86-perfscale-rosa-sdn-to-ovn-120nodes-periodic N/A periodic Periodic changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.12-nightly-x86-perfscale-rosa-sdn-to-ovn-24nodes-periodic N/A periodic Periodic changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-perfscale-aws-sdn-to-ovn-120nodes-periodic N/A periodic Periodic changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-perfscale-aws-sdn-to-ovn-24nodes-periodic N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@krishvoor
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.12-nightly-x86-perfscale-rosa-sdn-to-ovn-24nodes-periodic

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2023

@krishvoor: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.13-ocp-qe-perfscale-aws-sdn-to-ovn-120nodes-periodic 7ae3395d967dff72f70de9b2079b0031071e89db link unknown /pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.13-ocp-qe-perfscale-aws-sdn-to-ovn-120nodes-periodic
ci/rehearse/periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic 8dbf2262e4f60e29877e50b8c7f2c5b51f7fe8bd link unknown /pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic
ci/rehearse/periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.12-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic 8dbf2262e4f60e29877e50b8c7f2c5b51f7fe8bd link unknown /pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.12-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic
ci/rehearse/periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.13-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic 8dbf2262e4f60e29877e50b8c7f2c5b51f7fe8bd link unknown /pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.13-ocp-qe-perfscale-aws-sdn-to-ovn-24nodes-periodic
ci/build-farm/build04-dry d016ecc85c6db92be73837a314be7fad5e782d09 link true /test build04-dry
ci/build-farm/build01-dry d016ecc85c6db92be73837a314be7fad5e782d09 link true /test build01-dry
ci/build-farm/build09-dry ab82341 link true /test build09-dry
ci/rehearse/periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-perfscale-aws-sdn-to-ovn-24nodes-periodic a06bd36 link unknown /pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aws-4.14-nightly-x86-perfscale-aws-sdn-to-ovn-24nodes-periodic
ci/rehearse/periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.12-nightly-x86-perfscale-rosa-sdn-to-ovn-24nodes-periodic 28fe4b7 link unknown /pj-rehearse periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-rosa-4.12-nightly-x86-perfscale-rosa-sdn-to-ovn-24nodes-periodic

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@krishvoor
Copy link
Member Author

The recent job-logs needs to be a OpenshiftSDN type and needs to be explicitly set.

  "network": {
    "host_prefix": 23,
    "machine_cidr": "10.0.0.0/16",
    "pod_cidr": "10.128.0.0/14",
    "service_cidr": "172.30.0.0/16",
    "type": "OVNKubernetes"
  }

@krishvoor
Copy link
Member Author

This is blocked by #44633

@krishvoor
Copy link
Member Author

Switching to the approach of validating it on Self-Managed AWS.

@krishvoor krishvoor closed this Nov 6, 2023
@krishvoor krishvoor deleted the sdn-ovn-migration branch November 7, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svetsa-rh svetsa-rh svetsa-rh left review comments

@qiliRedHat qiliRedHat Awaiting requested review from qiliRedHat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@krishvoor @openshift-ci-robot @svetsa-rh @jtaleric @vishnuchalla @openshift-merge-robot