Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.13 backport] CI jobs for AWS Shared-VPC install #42047

Merged
merged 1 commit into from
Aug 9, 2023
Merged

[4.13 backport] CI jobs for AWS Shared-VPC install #42047

merged 1 commit into from
Aug 9, 2023

Conversation

yunjiang29
Copy link
Contributor

@yunjiang29 yunjiang29 commented Aug 7, 2023 •
edited
Loading

New jobs:

  • 4.13

    • aws-ipi-private-shared-vpc-phz-sts-f14
    • aws-ipi-private-shared-vpc-phz-sts-f28-destructive
    • aws-ipi-shared-vpc-phz-f14
    • aws-ipi-shared-vpc-phz-f28-destructive
    • aws-ipi-shared-vpc-phz-sts-fips-f14
    • aws-ipi-shared-vpc-phz-sts-fips-f28-destructive

  • 4.13 stable -> 4.14 nightly:

    • aws-ipi-shared-vpc-phz-sts-fips-f14
    • aws-ipi-shared-vpc-phz-f14

Note: 4.13.0-0.nightly-2023-08-08-191218 is available:

@yunjiang29 yunjiang29 changed the title [4.13 backport] AWS Shared-VPC install [4.13 backport] CI jobs for AWS Shared-VPC install Aug 7, 2023
@yunjiang29 yunjiang29 force-pushed the shared-vpc-413 branch 2 times, most recently from b3ddbe6 to 27230fa Compare August 8, 2023 01:52
@yunjiang29
Copy link
Contributor Author

@gpei @jiajliu @shellyyang1989 PTAL, thanks

@jiajliu
Copy link
Contributor

jiajliu commented Aug 8, 2023

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-4.14-upgrade-from-stable-4.13-aws-ipi-shared-vpc-phz-f14

@yunjiang29
Copy link
Contributor Author

/pj-rehearse abort

@yunjiang29
Copy link
Contributor Author

@jiajliu No available build for this feature at this moment as PRs were just merged a few hours ago. I will update the build number in the description once it's ready, sorry for confused info.

@yunjiang29
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2023
@openshift-ci-robot
Copy link
Contributor

@yunjiang29, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase repo client
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@yunjiang29
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-4.14-upgrade-from-stable-4.13-aws-ipi-shared-vpc-phz-f14

@yunjiang29
Copy link
Contributor Author

yunjiang29 commented Aug 9, 2023 •
edited
Loading

Job failed is b/c Prow is using 4.13.8 stable version, the feature is not available in it.

@yunjiang29
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
@jiajliu
Copy link
Contributor

jiajliu commented Aug 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@yunjiang29
Copy link
Contributor Author

@liangxia Can you approve this PR? thanks

liangxia
liangxia reviewed Aug 9, 2023
View reviewed changes
...t/openshift-tests-private/openshift-openshift-tests-private-release-4.13__amd64-nightly.yaml Outdated
@@ -102,7 +102,7 @@ resources:
memory: 4Gi
tests:
- as: alibaba-ipi-private-fips-f28-ui
cron: 33 1 29 * *
cron: 47 14 13 * *
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

[lxia@homepc tools]$ ./generate-cron-entry.sh alibaba-ipi-private-fips-f28-ui openshift-openshift-tests-private-release-4.13__amd64-nightly.yaml
cron: 33 1 29 * *

It looks like the cron entry does not require change on my side.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I think we can keep the other jobs' cron entry as previous, at least as I know the cron time for some of the GCP jobs were reconciled by Jianli on purpose as now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I used update-cron-entries.py to do a batch update.
Will fix it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liangxia @gpei PATL again, thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also made an update on update-cron-entries.py #42133 to make sure the output values are consistent, cc @jianlinliu for review

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 9, 2023
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 9, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@yunjiang29: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-private-shared-vpc-phz-sts-f14 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-shared-vpc-phz-f14 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-shared-vpc-phz-f28-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-private-shared-vpc-phz-sts-f28-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-4.14-upgrade-from-stable-4.13-aws-ipi-shared-vpc-phz-f14 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-f14 N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-aws-ipi-shared-vpc-phz-sts-fips-f28-destructive N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-4.14-upgrade-from-stable-4.13-aws-ipi-shared-vpc-phz-sts-fips-f14 N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@gpei
Copy link
Contributor

gpei commented Aug 9, 2023

/lgtm

@liangxia
Copy link
Member

liangxia commented Aug 9, 2023

/lgtm

@liangxia
Copy link
Member

liangxia commented Aug 9, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 9, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gpei, jiajliu, liangxia, yunjiang29

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@liangxia
Copy link
Member

liangxia commented Aug 9, 2023

/test core-valid

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

@yunjiang29: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-4.14-upgrade-from-stable-4.13-aws-ipi-shared-vpc-phz-f14 8bd4faa0e9785f8601b169c374019c19addf5e00 link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-4.14-upgrade-from-stable-4.13-aws-ipi-shared-vpc-phz-f14

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 838d212 into openshift:master Aug 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

@yunjiang29: Updated the following 4 configmaps:

  • ci-operator-4.14-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-tests-private-release-4.14__amd64-nightly-4.14-upgrade-from-stable-4.13.yaml using file ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.14__amd64-nightly-4.14-upgrade-from-stable-4.13.yaml
  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-tests-private-release-4.13-periodics.yaml using file ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.13-periodics.yaml
  • job-config-4.14 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-tests-private-release-4.14-periodics.yaml using file ci-operator/jobs/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.14-periodics.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-openshift-tests-private-release-4.13__amd64-nightly.yaml using file ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.13__amd64-nightly.yaml

In response to this:

New jobs:

  • 4.13

  • aws-ipi-private-shared-vpc-phz-sts-f14

  • aws-ipi-private-shared-vpc-phz-sts-f28-destructive

  • aws-ipi-shared-vpc-phz-f14

  • aws-ipi-shared-vpc-phz-f28-destructive

  • aws-ipi-shared-vpc-phz-sts-fips-f14

  • aws-ipi-shared-vpc-phz-sts-fips-f28-destructive

  • 4.13 stable -> 4.14 nightly:

  • aws-ipi-shared-vpc-phz-sts-fips-f14

  • aws-ipi-shared-vpc-phz-f14

Note: 4.13.0-0.nightly-2023-08-08-191218 is available:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yunjiang29 yunjiang29 mentioned this pull request Sep 12, 2023
Merged
@yunjiang29 yunjiang29 deleted the shared-vpc-413 branch January 2, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangxia liangxia liangxia left review comments

@gpei gpei gpei left review comments

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

@rioliu-rh rioliu-rh Awaiting requested review from rioliu-rh

Assignees

@liangxia liangxia

@jiajliu jiajliu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yunjiang29 @jiajliu @openshift-ci-robot @gpei @liangxia @openshift-merge-robot