CORS-2764: AWS Shared VPC Backport [release-4.13] #7362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: r4f4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retitle CORS-2764: AWS Shared VPC Backport [release-4.13] |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@patrickdillon: This pull request references CORS-2764 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
patrickdillon
force-pushed
the
413-aws-shared-vpc
branch
from
cf968b7 to
cc489ef
Compare
Adds a hosted zone role field. If provided, this role will be assumed whenever operations are performed on the provided hosted zone. This enables the private hosted zone to belong to a different account than the rest of the cluster.
If a hosted zone role is specified in the install config, users must also supply a hosted zone.
The hostedZoneRole will need to be used when destroying the cluster.
Updates the route53 clients to allow passing config with assume role credentials. This allows the function caller to determine whether the service should authenticate with the default credentials or creds for another account.
Add the ability to assume a role in a different account when destroying records in a private hosted zone. When the hostedZoneRole is passed in the metadata, that role will be used when running destroy.
Plumb the hosted zone role through to terraform, so that it can be used to create records when the hosted zone belongs to another account.
Adds the ability in terraform to assume a role when performing operations on a private hosted zone which belongs to a different account than the rest of the cluster.
Display to users any errors when retrieving a hosted zone specified in the install config.
When a hostedZoneRole is specified for an AWS shared VPC install, write it to the DNS config so it can be used by the cluster ingress operator.
Update tests and mocks due to changes for adding cross-account private hosted-zone support.
Adds validation to require that either manual or passthrough credentials mode is used when specifying hosted zone role. In order to perform the AssumeRole operation on the provided role, a policy must be in place to establish a trust reltionship between the role and the IAM credential (for the installer and ingress operator). Because mint mode will create new credentials with non-deterministic unique identifiers in the cluster, it is impossible to generate the policy in advance.
When users bring their own hosted zone, the installer no longer requires permissions to create or destroy zones.
Small refactoring of destroy code for increasing readibility for cross-account private hosted zones.
Improves wording of hostedZoneRole comment/godoc.
commands: go get github.com/openshift/[email protected] go mod edit -replace=github.com/openshift/api=github.com/openshift/[email protected] go mod tidy
go mod vendor
patrickdillon
force-pushed
the
413-aws-shared-vpc
branch
from
cc489ef to
0e97e7e
Compare
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label backport-risk-assessed QE has verified with pre-merge testing. |
openshift-ci
bot
added
the
backport-risk-assessed
mrunalp
added
cherry-pick-approved
|
/skip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.13 Backport of the AWS Shared VPC with cross-account private hosted zone