Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-3.11] admission: enable webhooks by default #20953

Closed
wants to merge 1 commit into from
Closed

[release-3.11] admission: enable webhooks by default #20953

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #20744

/assign sttts

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 12, 2018
Merged
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2018
@sttts
Copy link
Contributor

sttts commented Sep 12, 2018

/hold

until #20945 merged.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2018
@simo5
Copy link
Contributor

simo5 commented Sep 13, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, simo5
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: squeed

If they are not already assigned, you can assign the PR to them by writing /assign @squeed in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link
Contributor

sttts commented Sep 13, 2018

@deads2k approved?

@sttts
Copy link
Contributor

sttts commented Sep 14, 2018

/assign @soltysh

Approved?

@soltysh
Copy link
Contributor

soltysh commented Sep 14, 2018

This needs higher powers than mine, @derekwaynecarr or @mfojtik need to approve.

@derekwaynecarr
Copy link
Member

@sttts i sent a mail discussing this PR (and the other) to decide on outcome.

@derekwaynecarr
Copy link
Member

this will wait for 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh Awaiting requested review from soltysh

@squeed squeed Awaiting requested review from squeed

Assignees

@soltysh soltysh

@sttts sttts

@simo5 simo5

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @sttts @simo5 @openshift-ci-robot @soltysh @derekwaynecarr