-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.11] admission: split plugins into validating-only and mutating+validating #20945
Conversation
/retest |
1 similar comment
/retest |
@stevekuznetsov the extended_builds job is red, I can neither see logs nor restart it. Any idea? |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot, simo5 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@deads2k approved? |
/assign @smarterclayton Is this approved for 3.11? |
/retest |
{
"component": "jenkins-operator",
"error": "response not 201: 404 Not Found",
"event-GUID": "19663d50-b82d-11e8-9e25-ea9e89a2b4d2",
"job": "test_pull_request_origin_extended_builds-release-3.11",
"level": "warning",
"msg": "Cannot start Jenkins build",
"name": "19f4f81a-b82d-11e8-bc65-0a58ac100b2a",
"org": "openshift",
"pr": 20945,
"repo": "origin",
"time": "2018-09-14T14:47:45Z",
"type": "presubmit"
} @smarterclayton did you branch that job? |
@sttts i sent a mail discussing this PR (and the other) to decide on outcome. |
this will wait until 4.0. |
This is an automated cherry-pick of #20743
/assign sttts