Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.11] admission: split plugins into validating-only and mutating+validating #20945

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #20743

/assign sttts

@sttts
Copy link
Contributor

sttts commented Sep 12, 2018

/retest

1 similar comment
@sttts
Copy link
Contributor

sttts commented Sep 12, 2018

/retest

@bparees bparees removed their request for review September 12, 2018 14:02
@sttts
Copy link
Contributor

sttts commented Sep 12, 2018

@stevekuznetsov the extended_builds job is red, I can neither see logs nor restart it. Any idea?

@simo5
Copy link
Contributor

simo5 commented Sep 13, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, simo5
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link
Contributor

sttts commented Sep 13, 2018

/retest

@sttts
Copy link
Contributor

sttts commented Sep 13, 2018

@deads2k approved?

@sttts
Copy link
Contributor

sttts commented Sep 14, 2018

/assign @smarterclayton

Is this approved for 3.11?

@stevekuznetsov
Copy link
Contributor

/retest

@stevekuznetsov
Copy link
Contributor

{
  "component": "jenkins-operator",
  "error": "response not 201: 404 Not Found",
  "event-GUID": "19663d50-b82d-11e8-9e25-ea9e89a2b4d2",
  "job": "test_pull_request_origin_extended_builds-release-3.11",
  "level": "warning",
  "msg": "Cannot start Jenkins build",
  "name": "19f4f81a-b82d-11e8-bc65-0a58ac100b2a",
  "org": "openshift",
  "pr": 20945,
  "repo": "origin",
  "time": "2018-09-14T14:47:45Z",
  "type": "presubmit"
}

@smarterclayton did you branch that job?

@derekwaynecarr
Copy link
Member

@sttts i sent a mail discussing this PR (and the other) to decide on outcome.

@derekwaynecarr
Copy link
Member

this will wait until 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants