Resurrect extensions/v1beta1.HPA #14037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… extensions/v1beta1" This reverts commit e57b368.
|
[test] |
|
cc @smarterclayton re proto import question |
|
@sttts note, in order to regen the swagger spec in kube, I had to do this in our kube fork: diff --git a/hack/update-swagger-spec.sh b/hack/update-swagger-spec.sh
index bce02a7..b8b9172 100755
--- a/hack/update-swagger-spec.sh
+++ b/hack/update-swagger-spec.sh
@@ -67,6 +67,8 @@ kube::log::status "Starting kube-apiserver"
--etcd-servers="http://${ETCD_HOST}:${ETCD_PORT}" \
--advertise-address="10.10.10.10" \
--cert-dir="${TMP_DIR}/certs" \
+ --runtime-config="batch/v2alpha1" \
+ --runtime-config="autoscaling/v2alpha1" \
--service-cluster-ip-range="10.0.0.0/24" >/tmp/swagger-api-server.log 2>&1 &
APISERVER_PID=$! |
|
Evaluated for origin test up to 045cafa |
|
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1134/) (Base Commit: 4a5ee06) |
|
Stefan is going to finish this in his copy, closing mine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #14021 but with rewritten history to include updated protobuf etc from kube. I'm not sure why the autoscaling/v2alpha1 proto is importing extensions/v1beta1, but I assume genprotobuf knows what it's doing...