Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resurrect extensions/v1beta1.HPA #14021

Merged
merged 5 commits into from
May 15, 2017
Merged

Resurrect extensions/v1beta1.HPA #14021

merged 5 commits into from
May 15, 2017

Conversation

sttts
Copy link
Contributor

@sttts sttts commented May 3, 2017

No description provided.

@sttts sttts mentioned this pull request May 3, 2017
Closed
32 tasks
@sttts
Copy link
Contributor Author

sttts commented May 3, 2017

[test]

@ncdc
Copy link
Contributor

ncdc commented May 3, 2017

@sttts was most of UPSTREAM: <drop>: resurrect extensions/v1beta1.HPA just copy/paste from the last revision before it was dropped from extensions?

@sttts
Copy link
Contributor Author

sttts commented May 3, 2017

@ncdc plus a number of conversion fixes if I remember right, taken from your kubecompat commit.

@ncdc
Copy link
Contributor

ncdc commented May 3, 2017

@DirectXMan12 ptal

@sttts sttts force-pushed the sttts-extensions-hpa branch from 2465618 to 8c88c6e Compare May 3, 2017 15:47
@DirectXMan12
Copy link
Contributor

DirectXMan12 commented May 3, 2017 •
edited
Loading

the conversions seem reasonable, but you appear to be missing some protobuf pieces (so the round-trip test is failing on that).

@ncdc
Copy link
Contributor

ncdc commented May 3, 2017

I will have a PR shortly that fixes the protobuf issues. If that passes tests before @sttts is up tomorrow, we can merge it, or he can pick my commits and run with them.

@ncdc ncdc mentioned this pull request May 3, 2017
Closed
@ncdc
Copy link
Contributor

ncdc commented May 3, 2017

Ok mine is #14037

@sttts sttts mentioned this pull request May 5, 2017
Closed
@sttts sttts force-pushed the sttts-extensions-hpa branch from 8c88c6e to c6a261c Compare May 5, 2017 13:16
@sttts sttts force-pushed the sttts-extensions-hpa branch from c6a261c to c13bc35 Compare May 5, 2017 13:37
@sttts sttts mentioned this pull request May 5, 2017
Closed
@sttts sttts force-pushed the sttts-extensions-hpa branch from c13bc35 to 388eede Compare May 5, 2017 17:26
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 388eede

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/1206/) (Base Commit: 8160d8d)

@sttts
Copy link
Contributor Author

sttts commented May 5, 2017

@ncdc green

@sttts sttts assigned mfojtik and unassigned ncdc May 9, 2017
@sttts
Copy link
Contributor Author

sttts commented May 9, 2017

@mfojtik @DirectXMan12 ptal. this is green and waiting to merge.

@DirectXMan12
Copy link
Contributor

/lgtm

@sttts
Copy link
Contributor Author

sttts commented May 15, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 388eede

@openshift-bot
Copy link
Contributor

openshift-bot commented May 15, 2017 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/649/) (Base Commit: b38274c) (Image: devenv-rhel7_6228)

@openshift-bot openshift-bot merged commit b581bfe into openshift:master May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mfojtik mfojtik

@DirectXMan12 DirectXMan12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sttts @ncdc @DirectXMan12 @openshift-bot @mfojtik