Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete a redundant arg #11365

Merged
merged 1 commit into from
May 20, 2017
Merged

Conversation

miaoyq
Copy link
Contributor

@miaoyq miaoyq commented Oct 14, 2016

The arg id isn't used in the func schema0ToImage, I think we should delete it.

@legionus
Copy link
Contributor

LGTM

@legionus legionus added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2016
@legionus
Copy link
Contributor

@mfojtik /cc

@miaoyq
Copy link
Contributor Author

miaoyq commented Oct 18, 2016

@mfojtik /cc Thanks!

@php-coder
Copy link
Contributor

@mfojtik it's still mergeable and even approved by @legionus Could we merge it then?

@enj
Copy link
Contributor

enj commented May 16, 2017

[merge]

@enj
Copy link
Contributor

enj commented May 16, 2017

Flake #14197

@enj
Copy link
Contributor

enj commented May 19, 2017

Flake #14214

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 26d138d

@openshift-bot
Copy link
Contributor

openshift-bot commented May 20, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/713/) (Base Commit: 2c04b90) (Image: devenv-rhel7_6247)

@openshift-bot openshift-bot merged commit b85c7e3 into openshift:master May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/imageregistry lgtm Indicates that a PR is ready to be merged. priority/P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants