Skip to content

Commit

Permalink
Merge pull request #11365 from miaoyq/del-a-unused-arg
Browse files Browse the repository at this point in the history
Merged by openshift-bot
  • Loading branch information
OpenShift Bot authored May 20, 2017
2 parents 2c04b90 + 26d138d commit b85c7e3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/image/importer/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ func schema2ToImage(manifest *schema2.DeserializedManifest, imageConfig []byte,
return image, nil
}

func schema0ToImage(dockerImage *dockerregistry.Image, id string) (*api.Image, error) {
func schema0ToImage(dockerImage *dockerregistry.Image) (*api.Image, error) {
var baseImage api.DockerImage
if err := kapi.Scheme.Convert(&dockerImage.Image, &baseImage, nil); err != nil {
return nil, fmt.Errorf("could not convert image: %#v", err)
Expand Down
4 changes: 2 additions & 2 deletions pkg/image/importer/importer.go
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ func importRepositoryFromDockerV1(ctx gocontext.Context, repository *importRepos
continue
}
// we do not preserve manifests of legacy images
importDigest.Image, err = schema0ToImage(image, importDigest.Name)
importDigest.Image, err = schema0ToImage(image)
if err != nil {
importDigest.Err = err
continue
Expand All @@ -651,7 +651,7 @@ func importRepositoryFromDockerV1(ctx gocontext.Context, repository *importRepos
continue
}
// we do not preserve manifests of legacy images
importTag.Image, err = schema0ToImage(image, "")
importTag.Image, err = schema0ToImage(image)
if err != nil {
importTag.Err = err
continue
Expand Down

0 comments on commit b85c7e3

Please sign in to comment.