Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDEVDOCS-3308 [Recurring] Release Notes, Known Issues, and Bug Fixes… #38489

Closed
wants to merge 1 commit into from
Closed

RHDEVDOCS-3308 [Recurring] Release Notes, Known Issues, and Bug Fixes… #38489

wants to merge 1 commit into from

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Nov 8, 2021

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 8, 2021
@netlify
Copy link

netlify bot commented Nov 8, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: ce5eb2c

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61a64bfc69d34d000833520a

😎 Browse the preview: https://deploy-preview-38489--osdocs.netlify.app

@siamaksade
Copy link

Should the support matrix be limited to versions that are still supported (1.4+)?

@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 8, 2021

Should the support matrix be limited to versions that are still supported (1.4+)?

@siamaksade Sure. Since these changes are partially merged, I'll handle this in a separate PR from https://issues.redhat.com/browse/RHDEVDOCS-3463. (See https://github.com/openshift/openshift-docs/pull/38496/files)

@Preeticp Preeticp added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2021
@rolfedh
Copy link
Contributor Author

rolfedh commented Nov 11, 2021

/rebuild

// (link:https://issues.redhat.com/browse/SRVKP-1465[SRVKP-1465])

[id="known-issues-1-6_{context}"]
== Known issues
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would like to add another known issue:

If any namespace has a ResourceQuota object, the OpenShift Pipelines will resulting pods for TaskRuns or PipelineRuns will fail with an error like failed quota: <quota name> must specify cpu, memory. This happens because if a quota is defined, either all the containers must have explicit requests and limits OR a limit range should be specified for that namespace.
As a workaround, users can specify a limit range in the concerning namespace.
Detailed resolution here - https://access.redhat.com/solutions/2841971
Issue is being tracked here - https://issues.redhat.com/browse/SRVKP-1801

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfedh please note.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sounix000 Please work with @concaf to refine the proposed text on line 201.


[id="fixed-cli-0-21-0-1-6_{context}"]
=== CLI

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one behavior change that we want to point out for the CLI (tkn)

Previously, when any user would delete all resources using tkn (example: tkn pipelinerun delete --all), then all the resources regardless of their running status would get deleted, but in 1.6.0, the resources that are still in RUNNING state do not get deleted. This is reflected in the user facing output as well when the tkn command is run. This was tracked in https://issues.redhat.com/browse/SRVKP-1638

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the RN, the note should also be added here: https://docs.openshift.com/container-platform/4.9/cli_reference/tkn_cli/op-tkn-reference.html#pipelinerun-delete. I will take care up updating the link above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the new item for this on line 201 of modules/op-release-notes-1-6.adoc

// (link:https://github.com/tektoncd/triggers/pull/1103[#1103])

[id="new-features-pipelines-operator-1-6_{context}"]
=== {pipelines-title} Operator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update related to auto pruning functionality is missing.
@vdemeester @concaf @pradeepitm12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing items

  1. Disabling pipeline service account
  2. Updating feature flags using tektonconfig CR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VeereshAradhya Thanks for providing this information. To document release notes for these items, I need more information, such as a more complete description of the new feature and how the user can make use of it. This information must be similar in scope and detail to the other release notes visible here. Can you provide this information, link to a source for this information, such as a pull request or Jira item, or indicate who might be able to provide it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfedh Fresh from today's stand up: PR for auto-prunning - tektoncd/operator#410

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing items

  1. Disabling pipeline service account
  2. Updating feature flags using tektonconfig CR

@vdemeester @concaf @pradeepitm12 I cannot provide release notes for the items @VeereshAradhya mentions unless someone provides additional information.

Copy link
Member

@vdemeester vdemeester Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DIsabling pipeline service account

It is now possible to disable, cluster-wide, the creation of the pipeline service account. The rational for disabling pipeline builtin service account, is for security-concerned cluster-admin that do not want their user to have a slight privilege escalation as the pipeline comes with a SCC very similar to anyuid

Updating feature-flags and configuration using the Operator's CRDs

It is now possible to configure feature-flags and component configuration directly from the TektonConfig CR (and the per-component CR TektonPipeline, TektonTriggers, …). This allows user to customize their OpenShift Pipelines instances as well as enabling alpha features, such as Custom Tasks or Tekton OCI Bundle.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

** Optional Timeouts field on PipelineRun **

It is now possible to configure more timeouts on the PipelineRun. There is a timeout for the pipeline execution, per-task execution and for the finally tasks execution.

** TaskRun Pods are now in the "terminating" quota **

Pods generated by Tekton TaskRuns are now setting the activeDeadlineSeconds field on Pods, making them considered as Terminating for Kubernetes. This helps supporting ResourceQuota a bit better as now Tekton Pipeline's pod are considered terminating and thus can be using a specific scoped ResourceQuota for those.

** Add Configuration for Metrics Cardinality Simplification **

Metrics tags/labels type on taskrun/pipelinerun and task/pipeline can be eliminated metrics using configmap. Also, the type of metrics for duration - histogram or gauge/last value, can also be configured.

** Better LimitRange support **

Tekton now supports fully LimitRange by taking into account the Min, Max, Default and DefaultRequest fields to define a coherent Requests and Limits on the Pod.

** Alpha Features **

  • Graceful PipelineRun Termination *

PipelineRun can now be stopped gracefully than the previous cancellation behavior that would stop the execution of all TaskRun directly and not running finally Task. This now adds the following spec.status values:

  • StoppedRunFinally to stop the current tasks (let them complete) and then run the finally tasks
  • CancelledRunFinally to cancel the current tasks (interupt any execution) and then run the finally tasks
  • Cancelled to keep the same behavior as previous PipelineRunCancelled status.

The status "PipelineRunCancelled" is deprecated and replaced by "Cancelled" (it would be removed in v1).

  • Debug TaskRun with breakpoint onFailure *

It is possible to put a TaskRun into debug mode, that will pause the execution and allow the user to get into the specific step (inside the Pod) using, for example, oc debug.

  • onError behaviour for Steps *

When onError is set to continue, the Step's exit code is recorded and made available to subsequent Steps via two new variables in Tasks. A Step with onError set to continue does not fail a TaskRun and continues executing the rest of the steps in a task. The default value to onError is stopAndFail to keep the current behavior.

  • Implement implicit parameter resolution. *

Tasks can now accept more parameters than are actually used. Parameters can now be implicitly propagated to inlined specs (alpha feature flag must be enabled) - e.g. an inlined Task can access parameters of its parent PipelineRun without needing to explicitly define each param.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be added in ** Alpha Features **

  • Skiping Strategies *

When Expressions are changing scope: in a future release (and today, if you enable the flag) a when stanza will guard only the Task it is attached to instead of the Task and all of its dependents. To guard both a Task and its dependents the when stanza will need to be attached to each dependent Task as well.

This should also be added to the Deprecation notice, as this change will roll out for all users of v1beta1 resources in 9 months, per our beta deprecation policy, and will be the default behaviour for When Expressions in any new apiVersions of Tekton's resources going forward. Thus it will most likely change in 1.8 or 1.9.


With this update, {pipelines-title} General Availability (GA) 1.6 is available on {product-title} 4.9.

[id="new-features-1-6_{context}"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New features from Pipelines component is missing.
@vdemeester @concaf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VeereshAradhya @vdemeester @concaf Thanks for providing this information. To document release notes for these items, I need more information, such as a more complete description of the new feature and how the user can make use of it. This information must be similar in scope and detail to the other release notes visible here. Can you provide this information, link to a source for this information, such as a pull request or Jira item, or indicate who might be able to provide it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rolfedh - The lack of information was discussed in the stand up call today. Nikhil, Vincent, and others will be giving you information soon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vdemeester @concaf @pradeepitm12 I cannot provide release notes for the items @VeereshAradhya mentions unless someone provides additional information.

@ppitonak
Copy link

Please add a note about broken s2i image https://issues.redhat.com/browse/SRVKP-1782

Workaround: <workaround>.

[id="fixed-issues-1-6_{context}"]
== Fixed issues

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tektoncd/pipeline#4075 can go to pipelines section of fixed issues
@vdemeester @concaf

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes @VeereshAradhya 👍🏼

@sounix000
Copy link
Contributor

@rolfedh I have opened a new PR #39389. You can close yours.

@rolfedh rolfedh closed this Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.9 branch/enterprise-4.10 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants