-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS-3307 Resource quota for pipelines #38478
RHDEVDOCS-3307 Resource quota for pipelines #38478
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: ee13160 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61a5e170a439d10008ae734b 😎 Browse the preview: https://deploy-preview-38478--osdocs.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to define the problem that we're trying to solve more concretely.
Also since we don't have a built-in solution yet, we need to share a few recommendations with our customers because this is not a one size fits all solution.
We should include this part -
Resource requests and limits can be set on a per Step basis:
https://tekton.dev/docs/pipelines/tasks/#defining-steps
Resource limits can be set via LimitRange:
https://tekton.dev/docs/pipelines/pipelineruns/#specifying-limitrange-values
Follow guidelines around reducing resource consumption of Pipelines:
https://docs.openshift.com/container-platform/4.8/cicd/pipelines/reducing-pipelines-resource-consumption.html
Also broadly, to restrict resource consumption in your project, a user can:
Set and manage resource quotas to limit the aggregate resource consumption - https://docs.openshift.com/container-platform/4.8/applications/quotas/quotas-setting-per-project.html
Use limit ranges to restrict resource consumption for specific objects, such as pods, images, image streams, and persistent volume claims. - https://docs.openshift.com/container-platform/4.8/nodes/clusters/nodes-cluster-limit-ranges.html
we also need to talk about generic pipelines and parameterisation.
@concaf - Regarding your comment about generic pipelines and parameterization - I have included tips about generic pipelines, but I can't include parameterization because it is futuristic in nature (the GitHub issues you mentioned in your G-doc draft). We are not allowed to include such futuristic commitments in our downstream documentation. |
cicd/pipelines/setting-compute-resource-quota-for-pipelines.adoc
Outdated
Show resolved
Hide resolved
cicd/pipelines/setting-compute-resource-quota-for-openshift-pipelines.adoc
Outdated
Show resolved
Hide resolved
cicd/pipelines/setting-compute-resource-quota-for-openshift-pipelines.adoc
Outdated
Show resolved
Hide resolved
modules/op-alternative-approaches-compute-resource-quota-pipelines.adoc
Outdated
Show resolved
Hide resolved
modules/op-specifying-pipelines-resource-quota-using-priority-class.adoc
Outdated
Show resolved
Hide resolved
modules/op-specifying-pipelines-resource-quota-using-priority-class.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Souvik, I'm pre-approving this PR based on the expectation that you'll evaluate the suggestions and apply the ones that make sense. I noticed a couple of missing articles and took the opportunity to also trim down the sentences and (I hope) improve their clarity.
structural changes actual content added minor edits incorporating comments and refactoring incorporated comments and removed a redundant module fixed file path fixed file path fixed file path fixed file paths fixed path errors incorporated peer review comments build error resolution build error resolution build error resolution
/cherrypick enterprise-4.9 |
/cherrypick enterprise-4.10 |
@Preeticp: new pull request created: #39352 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Preeticp: new pull request created: #39353 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
enterprise-4.9
,enterprise-4.10