daemon: Don't do OS updates/pivoting on !RHCOS #454
Conversation
openshift-ci-robot
added
approved
Without this we end up in a reboot loop. Happened for the UPI scaleup tests on CentOS (classic).
cgwalters
force-pushed
the
no-pivot-not-rhcos
branch
from
68f8b56 to
748df43
Compare
openshift-ci-robot
added
size/S
|
Looks like #451 hit the unit test. /test unit |
|
HAProxy Router, EBS, TestKubletConfig flakes /retest |
|
This looks good to me, any way anyone can live test it out? Otherwise, I believe this is right |
|
I'm actually going to approve and lgtm as it's the right fix anyway afaict /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Remember it won't get in if it doesn't pass CI, so I often lgtm before tests are known to pass. |
yeah, I just wanted someone to actually test this fix live but I get it's not that straightforward and wanted to prevent a merge with my lgtm if it turned out to be wrong, but again, this is correct anyway |
|
network runtime bug again /retest |
|
aws limit, will retest in some minutes |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
unit flake #449 |
|
/retest |
Without this we end up in a reboot loop. Happened
for the UPI scaleup tests on CentOS (classic).