Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestKubeletConfigUpdates flake #451

Closed
runcom opened this issue Feb 17, 2019 · 6 comments · Fixed by #457
Closed

TestKubeletConfigUpdates flake #451

runcom opened this issue Feb 17, 2019 · 6 comments · Fixed by #457
Assignees

Comments

@runcom
Copy link
Member

runcom commented Feb 17, 2019

Similar to #417 and #444, seen in https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/450/pull-ci-openshift-machine-config-operator-master-unit/1222

--- FAIL: TestKubeletConfigUpdates (0.17s)
    --- PASS: TestKubeletConfigUpdates/aws (0.09s)
    --- FAIL: TestKubeletConfigUpdates/none (0.02s)
    	kubelet_config_controller_test.go:213: Expected
    			testing.UpdateActionImpl{ActionImpl:testing.ActionImpl{Namespace:"", Verb:"update", Resource:schema.GroupVersionResource{Group:"", Version:"", Resource:"machineconfigs"}, Subresource:""}, Object:(*v1.MachineConfig)(0xc4203b2a00)}
    		got
    			testing.UpdateActionImpl{ActionImpl:testing.ActionImpl{Namespace:"", Verb:"update", Resource:schema.GroupVersionResource{Group:"machineconfiguration.openshift.io", Version:"v1", Resource:"kubeletconfigs"}, Subresource:"status"}, Object:(*v1.KubeletConfig)(0xc420132500)}
    	kubelet_config_controller_test.go:76: 2 additional expected actions:[{ActionImpl:{Namespace: Verb:patch Resource:{Group:machineconfiguration.openshift.io Version:v1 Resource:kubeletconfigs} Subresource:} Name:smaller-max-pods Patch:[123 34 109 101 116 97 100 97 116 97 34 58 123 34 102 105 110 97 108 105 122 101 114 115 34 58 91 34 57 57 45 109 97 115 116 101 114 45 109 119 119 116 103 45 107 117 98 101 108 101 116 34 93 125 125]} {ActionImpl:{Namespace: Verb:update Resource:{Group:machineconfiguration.openshift.io Version:v1 Resource:kubeletconfigs} Subresource:status} Object:0xc4203aef00}]

/cc @sjenning @rphillips

@sjenning
Copy link
Contributor

/assign @rphillips

@runcom
Copy link
Member Author

runcom commented Feb 18, 2019

notice that the test may be also flake somehow #417 (comment)

@runcom
Copy link
Member Author

runcom commented Feb 18, 2019

notice that the test setup and run may be also flake somehow #417 (comment)

@kikisdeliveryservice
Copy link
Contributor

@runcom are these flakes blocking or do they go away after multiple retries?

@runcom
Copy link
Member Author

runcom commented Feb 18, 2019

They go away

@kikisdeliveryservice
Copy link
Contributor

thanks @runcom managed to get past it on a PR but seeing it frequently in CI today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants