Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-24396: Allow setting overprovision ratio to 1 #518

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: allow setting overprovision ratio to 1
Signed-off-by: Suleyman Akbas <[email protected]>
suleymanakbas91 committed Dec 5, 2023
commit 02eeff3a3106666a9116ba1eae11d26b21f50cf9
2 changes: 1 addition & 1 deletion api/v1alpha1/lvmcluster_types.go
Original file line number Diff line number Diff line change
@@ -48,7 +48,7 @@ type ThinPoolConfig struct {

// OverProvisionRatio is the factor by which additional storage can be provisioned compared to
// the available storage in the thin pool.
// +kubebuilder:validation:Minimum=2
// +kubebuilder:validation:Minimum=1
// +kubebuilder:validation:Required
// +required
OverprovisionRatio int `json:"overprovisionRatio"`
2 changes: 1 addition & 1 deletion bundle/manifests/lvm.topolvm.io_lvmclusters.yaml
Original file line number Diff line number Diff line change
@@ -199,7 +199,7 @@ spec:
description: OverProvisionRatio is the factor by which
additional storage can be provisioned compared to
the available storage in the thin pool.
minimum: 2
minimum: 1
type: integer
sizePercent:
default: 90
2 changes: 1 addition & 1 deletion bundle/manifests/lvm.topolvm.io_lvmvolumegroups.yaml
Original file line number Diff line number Diff line change
@@ -158,7 +158,7 @@ spec:
description: OverProvisionRatio is the factor by which additional
storage can be provisioned compared to the available storage
in the thin pool.
minimum: 2
minimum: 1
type: integer
sizePercent:
default: 90
2 changes: 1 addition & 1 deletion config/crd/bases/lvm.topolvm.io_lvmclusters.yaml
Original file line number Diff line number Diff line change
@@ -195,7 +195,7 @@ spec:
description: OverProvisionRatio is the factor by which
additional storage can be provisioned compared to
the available storage in the thin pool.
minimum: 2
minimum: 1
type: integer
sizePercent:
default: 90
2 changes: 1 addition & 1 deletion config/crd/bases/lvm.topolvm.io_lvmvolumegroups.yaml
Original file line number Diff line number Diff line change
@@ -158,7 +158,7 @@ spec:
description: OverProvisionRatio is the factor by which additional
storage can be provisioned compared to the available storage
in the thin pool.
minimum: 2
minimum: 1
type: integer
sizePercent:
default: 90
2 changes: 1 addition & 1 deletion docs/design/thin-provisioning.md
Original file line number Diff line number Diff line change
@@ -46,7 +46,7 @@ The LVMS will create a thin pool LV in the Volume Group in order to create thinl

+ // OverProvisionRatio represents the ratio of overprovision that can
+ // be allowed on thin pools
+ // +kubebuilder:validation:Minimum=2
+ // +kubebuilder:validation:Minimum=1
+ OverprovisionRatio int `json:"overprovisionRatio,omitempty"`
}