Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-24396: Allow setting overprovision ratio to 1 #518

Merged

Conversation

suleymanakbas91
Copy link
Contributor

No description provided.

Signed-off-by: Suleyman Akbas <[email protected]>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 5, 2023
@openshift-ci-robot
Copy link

@suleymanakbas91: This pull request references Jira Issue OCPBUGS-24396, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from radeore December 5, 2023 10:30
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 5, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakobmoellerdev, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jakobmoellerdev,suleymanakbas91]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2b8bb7d into openshift:main Dec 5, 2023
9 checks passed
@openshift-ci-robot
Copy link

@suleymanakbas91: Jira Issue OCPBUGS-24396: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-24396 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suleymanakbas91
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot

@suleymanakbas91: new pull request created: #520

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suleymanakbas91
Copy link
Contributor Author

/cherry-pick release-4.12

1 similar comment
@suleymanakbas91
Copy link
Contributor Author

/cherry-pick release-4.12

@openshift-cherrypick-robot

@suleymanakbas91: #518 failed to apply on top of branch "release-4.12":

Applying: fix: allow setting overprovision ratio to 1
Using index info to reconstruct a base tree...
M	api/v1alpha1/lvmcluster_types.go
M	bundle/manifests/lvm.topolvm.io_lvmclusters.yaml
M	bundle/manifests/lvm.topolvm.io_lvmvolumegroups.yaml
M	config/crd/bases/lvm.topolvm.io_lvmclusters.yaml
M	config/crd/bases/lvm.topolvm.io_lvmvolumegroups.yaml
A	docs/design/thin-provisioning.md
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): docs/design/thin-provisioning.md deleted in HEAD and modified in fix: allow setting overprovision ratio to 1. Version fix: allow setting overprovision ratio to 1 of docs/design/thin-provisioning.md left in tree.
Auto-merging config/crd/bases/lvm.topolvm.io_lvmvolumegroups.yaml
Auto-merging config/crd/bases/lvm.topolvm.io_lvmclusters.yaml
Auto-merging bundle/manifests/lvm.topolvm.io_lvmvolumegroups.yaml
Auto-merging bundle/manifests/lvm.topolvm.io_lvmclusters.yaml
Auto-merging api/v1alpha1/lvmcluster_types.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: allow setting overprovision ratio to 1
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants