Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates lvmvolumegroupnodestatus for vg #110

Merged
merged 1 commit into from
Feb 15, 2022
Merged

fix: updates lvmvolumegroupnodestatus for vg #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pkg/vgmanager/vgmanager_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,12 +318,10 @@ func setStatus(status *lvmv1alpha1.VGStatus, instance *lvmv1alpha1.LVMVolumeGrou
found := false

vgStatuses := instance.Spec.LVMVGStatus
for _, vgStatus := range vgStatuses {
for i, vgStatus := range vgStatuses {
if vgStatus.Name == status.Name {
found = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • not toggling found may create a new vgstatus as per condition in line 331
  • so found should still be set to true 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that was removed by mistake. I will update the PR.

vgStatus.Status = status.Status
vgStatus.Reason = status.Reason
vgStatus.Devices = status.Devices
vgStatuses[i] = *status
break
}
}
Expand Down