fix: updates lvmvolumegroupnodestatus for vg #110
Conversation
openshift-ci
bot
added
the
approved
| if vgStatus.Name == status.Name { | ||
| found = true |
There was a problem hiding this comment.
- not toggling
foundmay create a new vgstatus as per condition in line 331 - so
foundshould still be set totrue🤔
There was a problem hiding this comment.
Yes, that was removed by mistake. I will update the PR.
Fixes a bug where the lvmvolumegroupnodestatus was not updated correctly for an existing VG. When adding a new device and restarting the vg-manager pod, the device is added to the LVM VG but is not updated in the lvmvolumegroupnodestatus or the LVMCluster status. Signed-off-by: N Balachandran <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, nbalacha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.10 |
|
@nbalacha: new pull request created: #112 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes a bug where the lvmvolumegroupnodestatus was not updated correctly
for an existing VG. When adding a new device and restarting the
vg-manager pod, the device is added to the LVM VG but is not updated in
the lvmvolumegroupnodestatus or the LVMCluster status.
fixes: #105
Signed-off-by: N Balachandran [email protected]