Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.15] handler: Retry nncp status updated on error #535

Conversation

mkowalski
Copy link

@mkowalski mkowalski commented Oct 10, 2024

Cherry-picks 23f88eb

At node reboot the NNCP get re-apply but nmstate-webhook may not be
ready so it fails, this change add a retry on error at nncp status
update to prevent this. Not that Reconcile cycle is not call since this
is done at a "defer" call.

Signed-off-by: Enrique Llorente <[email protected]>
@openshift-ci openshift-ci bot requested review from phoracek and RamLavi October 10, 2024 06:06
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2024
@mkowalski
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2024
@mkowalski
Copy link
Author

/retest-required

@qinqon
Copy link

qinqon commented Nov 26, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2024
Copy link

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkowalski
Copy link
Author

/retest

@mkowalski
Copy link
Author

/override ci/prow/security

@mkowalski
Copy link
Author

/hold cancel

Copy link

openshift-ci bot commented Jan 22, 2025

@mkowalski: Overrode contexts on behalf of mkowalski: ci/prow/security

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2025
Copy link

openshift-ci bot commented Jan 22, 2025

@mkowalski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security f78ab63 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b13c0e8 into openshift:release-4.15 Jan 22, 2025
8 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-kubernetes-nmstate-operator
This PR has been included in build ose-kubernetes-nmstate-operator-container-v4.15.0-202501220935.p0.gb13c0e8.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-kubernetes-nmstate-handler
This PR has been included in build openshift-kubernetes-nmstate-handler-rhel-9-container-v4.15.0-202501220935.p0.gb13c0e8.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants