-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.15] handler: Retry nncp status updated on error #535
[4.15] handler: Retry nncp status updated on error #535
Conversation
At node reboot the NNCP get re-apply but nmstate-webhook may not be ready so it fails, this change add a retry on error at nncp status update to prevent this. Not that Reconcile cycle is not call since this is done at a "defer" call. Signed-off-by: Enrique Llorente <[email protected]>
/hold |
/retest-required |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/override ci/prow/security |
/hold cancel |
@mkowalski: Overrode contexts on behalf of mkowalski: ci/prow/security In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@mkowalski: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
b13c0e8
into
openshift:release-4.15
[ART PR BUILD NOTIFIER] Distgit: openshift-kubernetes-nmstate-operator |
[ART PR BUILD NOTIFIER] Distgit: openshift-kubernetes-nmstate-handler |
Cherry-picks 23f88eb