handler: Retry nncp status updated on error #1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At node reboot the NNCP get re-apply but nmstate-webhook may not be ready so it fails, this change add a retry on error at nncp status update to prevent this. Not that Reconcile cycle is not call since this is done at a "defer" call. Signed-off-by: Enrique Llorente <[email protected]>
kubevirt-bot
added
kind/bug
release-note
|
/lgtm |
mkowalski
approved these changes
Oct 8, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
mkowalski
pushed a commit
to mkowalski/kubernetes-nmstate
that referenced
this pull request
Oct 10, 2024
At node reboot the NNCP get re-apply but nmstate-webhook may not be ready so it fails, this change add a retry on error at nncp status update to prevent this. Not that Reconcile cycle is not call since this is done at a "defer" call. Signed-off-by: Enrique Llorente <[email protected]>
mkowalski
pushed a commit
to mkowalski/kubernetes-nmstate
that referenced
this pull request
Oct 10, 2024
At node reboot the NNCP get re-apply but nmstate-webhook may not be ready so it fails, this change add a retry on error at nncp status update to prevent this. Not that Reconcile cycle is not call since this is done at a "defer" call. Signed-off-by: Enrique Llorente <[email protected]>
mkowalski
pushed a commit
to mkowalski/kubernetes-nmstate
that referenced
this pull request
Oct 10, 2024
At node reboot the NNCP get re-apply but nmstate-webhook may not be ready so it fails, this change add a retry on error at nncp status update to prevent this. Not that Reconcile cycle is not call since this is done at a "defer" call. Signed-off-by: Enrique Llorente <[email protected]>
mkowalski
pushed a commit
to mkowalski/kubernetes-nmstate
that referenced
this pull request
Oct 10, 2024
At node reboot the NNCP get re-apply but nmstate-webhook may not be ready so it fails, this change add a retry on error at nncp status update to prevent this. Not that Reconcile cycle is not call since this is done at a "defer" call. Signed-off-by: Enrique Llorente <[email protected]>
mkowalski
pushed a commit
to mkowalski/kubernetes-nmstate
that referenced
this pull request
Oct 16, 2024
At node reboot the NNCP get re-apply but nmstate-webhook may not be ready so it fails, this change add a retry on error at nncp status update to prevent this. Not that Reconcile cycle is not call since this is done at a "defer" call. Signed-off-by: Enrique Llorente <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a BUG FIX or a FEATURE ?:
/kind bug
What this PR does / why we need it:
At node reboot the NNCP get re-apply but nmstate-webhook may not be ready so it fails, this change add a retry on error at nncp status update to prevent this. Not that Reconcile cycle is not call since this is done at a "defer" call.
Release note: