[4.16] handler: Retry nncp status updated on error #534
Conversation
At node reboot the NNCP get re-apply but nmstate-webhook may not be ready so it fails, this change add a retry on error at nncp status update to prevent this. Not that Reconcile cycle is not call since this is done at a "defer" call. Signed-off-by: Enrique Llorente <[email protected]>
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test unit |
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski, qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
13 similar comments
|
/retest-required |
|
/test e2e-handler-ovn-ipv4 |
|
/override ci/prow/security |
|
@mkowalski: Overrode contexts on behalf of mkowalski: ci/prow/security In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mkowalski: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit ca64b42
into
openshift:release-4.16
|
[ART PR BUILD NOTIFIER] Distgit: openshift-kubernetes-nmstate-handler |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-kubernetes-nmstate-operator |
Cherry-picks 23f88eb