Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: <carry>: Enable LLDP test downstream #478

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

UPSTREAM: <carry>: Enable LLDP test downstream #478

wants to merge 3 commits into from

Conversation

mkowalski
Copy link

No description provided.

@mkowalski
Copy link
Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2024
@openshift-ci openshift-ci bot requested review from phoracek and RamLavi April 29, 2024 17:07
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@mkowalski
Copy link
Author

/test unit

@qinqon
Copy link

qinqon commented Apr 30, 2024

/retest

Not related

/hack/ssh-ci.shmaster-0 -- /usr/bin/nmcli c s : ssh: connect to host 128.31.20.106 port 22: Connection refused
       exit status 255
      {
          s: "./hack/ssh-ci.shmaster-0 -- /usr/bin/nmcli c s : ssh: connect to host 128.31.20.106 port 22: Connection refused\r\n exit status 255",
      }

qinqon
qinqon suggested changes Apr 30, 2024
View reviewed changes
hack/ocp-e2e-tests-handler.sh Outdated Show resolved Hide resolved
@mkowalski mkowalski mentioned this pull request Apr 30, 2024
Merged
@qinqon
Copy link

qinqon commented Apr 30, 2024

/hold

Depends on #479

@mkowalski
Copy link
Author

/hold cancel
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2024
@qinqon
Copy link

qinqon commented May 8, 2024

/retest

  * could not run steps: step [release-inputs:initial] failed: failed to wait for importing imagestreamtags on ci-op-jsh6mb6h/stable-initial: failed to reimport the tag ci-op-jsh6mb6h/stable-initial:agent-installer-api-server: unable to import tag ci-op-jsh6mb6h/stable-initial:agent-installer-api-server with message dockerimage.image.openshift.io "quay.io/openshift/ci:ci-op-jsh6mb6h_stable-initial_agent-installer-api-server" not found on the image stream even after (6) imports: timed out waiting for the condition 
�[36mINFO�[0m[2024-05-08T10:29:24Z] Reporting job state 'failed' with reason 'executing_graph:step_failed:creating_release_images'

@mkowalski
Copy link
Author

/retest-required

{  failed to wait for importing imagestreamtags on ci-op-jsh6mb6h/stable-initial: timed out waiting for the condition}

@qinqon
Copy link

qinqon commented May 8, 2024

@mkowalski I don't understand the error from last run.

@mkowalski
Copy link
Author

/retest-required

{  failed to wait for importing imagestreamtags on ci-op-jsh6mb6h/stable-initial: timed out waiting for the condition}

It's PROW's issue, it crashed before our test suite even had a chance to run

@qinqon
Copy link

qinqon commented May 9, 2024

/retest

3 similar comments
@mkowalski
Copy link
Author

/retest

@mkowalski
Copy link
Author

/retest

@mkowalski
Copy link
Author

/retest

@mkowalski
Copy link
Author

/test e2e-handler-ovn-ipv4

OCP 4.18 fails, not a surprise

@mkowalski
Copy link
Author

/retest

@mkowalski
Copy link
Author 

  > Enter �[1m[AfterEach]�[0m when desiredState is updated with ovs-bridge with link aggregation port �[38;5;243m- /go/src/github.com/openshift/kubernetes-nmstate/test/e2e/handler/simple_ovs_bridge_and_bond_test.go:129 @ 08/12/24 10:49:56.471�[0m
Update error: admission webhook "nodenetworkconfigurationpolicies-update-validate.nmstate.io" denied the request: failed to admit NodeNetworkConfigurationPolicy test-policy: message: invalid policy operation: capture field cannot be modified.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2024
@mkowalski
Copy link
Author

/retest

@mkowalski
Copy link
Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 29, 2024
@mkowalski
Copy link
Author

/retest

Enormous amount of

Update error: admission webhook "nodenetworkconfigurationpolicies-update-validate.nmstate.io" denied the request: failed to admit NodeNetworkConfigurationPolicy test-policy: message: invalid policy operation: capture field cannot be modified.

Potentially a real failure. Let's see

@mkowalski
Copy link
Author

/test e2e-handler-sdn-ipv4

Trying without "with capture" to check if test "LLDP configuration with nmpolicy" will be skipped or not

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 2, 2024

@mkowalski: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test check-generate-bundle

/test e2e-handler-ovn-ipv4

/test e2e-operator-ovn-ipv4

/test images

/test security

/test unit

The following commands are available to trigger optional jobs:

/test e2e-handler-azure

Use /test all to run all jobs.

In response to this:

/test e2e-handler-sdn-ipv4

Trying without "with capture" to check if test "LLDP configuration with nmpolicy" will be skipped or not

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mkowalski
Copy link
Author

/test e2e-handler-ovn-ipv4

1 similar comment
@mkowalski
Copy link
Author

/test e2e-handler-ovn-ipv4

mkowalski and others added 2 commits December 3, 2024 10:58
@mkowalski
UPSTREAM: <carry>: Enable LLDP test downstream
74fec79
@qinqon @mkowalski
e2e, handler, ovs: Use secondary interfaces vars. (nmstate#1275)
3956449 
There are some e2e test for the handler that try to discover the
secondary interfaces stating "ipv4.enabled==false" this is wrong since
those interfaces could part of a primary interface ovs bridge and that
will match.

This change just use the e2e passed env var that state those interfaces.

Signed-off-by: Enrique Llorente <[email protected]>
@mkowalski
Copy link
Author

/test e2e-handler-ovn-ipv4

@qinqon
Copy link

qinqon commented Dec 3, 2024

/test e2e-handler-ovn-ipv4
not related

�[31mERRO�[0m[2024-12-03T15:36:47Z] 
  * could not run steps: step e2e-handler-ovn-ipv4 failed: failed to acquire lease for "equinix-ocp-metal-quota-slice": status 502 Bad Gateway, status code 502

@mkowalski
Copy link
Author

/test e2e-handler-ovn-ipv4

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 6, 2024 •
edited
Loading

@mkowalski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-handler-sdn-ipv4 05ad394 link true /test e2e-handler-sdn-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@phoracek
Copy link
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qinqon qinqon qinqon requested changes

@phoracek phoracek Awaiting requested review from phoracek

@RamLavi RamLavi Awaiting requested review from RamLavi

Assignees

@qinqon qinqon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkowalski @qinqon @openshift-bot @phoracek