e2e, handler, ovs: Use secondary interfaces vars. #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some e2e test for the handler that try to discover the secondary interfaces stating "ipv4.enabled==false" this is wrong since those interfaces could part of a primary interface ovs bridge and that will match. This change just use the e2e passed env var that state those interfaces. Signed-off-by: Enrique Llorente <[email protected]>
kubevirt-bot
added
release-note-none
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
mkowalski
pushed a commit
to mkowalski/kubernetes-nmstate
that referenced
this pull request
Dec 3, 2024
There are some e2e test for the handler that try to discover the secondary interfaces stating "ipv4.enabled==false" this is wrong since those interfaces could part of a primary interface ovs bridge and that will match. This change just use the e2e passed env var that state those interfaces. Signed-off-by: Enrique Llorente <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There are some e2e test for the handler that try to discover the secondary interfaces stating "ipv4.enabled==false" this is wrong since those interfaces could part of a primary interface ovs bridge and that will match.
This change just use the e2e passed env var that state those interfaces.
Release note: