NE-1323: Add default to AWS credentials field

[gcs278]

By adding a default value to the spec.provider.aws.credentials field, it enables the configuration of spec.provider.aws.assumeRole for an OpenShift user that doesn't need to explicitly specify the credentials field. Otherwise, an OpenShift user must manually insert "" as the credentials name to use the assumeRole field.

This improves user experience for the current v1beta1 release of ExternalDNS Operator while not introducing any breaking changes to the API. We are planning to properly fix this issue in a future ExternalDNS Operator API version by converting Credentials to an optional pointer.

Epic: https://issues.redhat.com/browse/NE-1299

[openshift-ci-robot]

@gcs278: This pull request references NE-1323 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

By adding a default value to the spec.provider.aws.credentials field, it enables the configuration of spec.provider.aws.assumeRole for an OpenShift user that doesn't need to explicitly specify the credentials field. Otherwise, an OpenShift user must manually insert "" as the credentials name to use the assumeRole field.

This improves user experience for the current v1beta1 release of ExternalDNS Operator while not introducing any breaking changes to the API. We are planning to properly fix this issue in a future ExternalDNS Operator API version by converting Credentials to an optional pointer.

Epic: https://issues.redhat.com/browse/NE-1299

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alebedev87]

/retest

[alebedev87]

/lgtm

[openshift-ci-robot]

@gcs278: This pull request references NE-1323 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

By adding a default value to the spec.provider.aws.credentials field, it enables the configuration of spec.provider.aws.assumeRole for an OpenShift user that doesn't need to explicitly specify the credentials field. Otherwise, an OpenShift user must manually insert "" as the credentials name to use the assumeRole field.

This improves user experience for the current v1beta1 release of ExternalDNS Operator while not introducing any breaking changes to the API. We are planning to properly fix this issue in a future ExternalDNS Operator API version by converting Credentials to an optional pointer.

Epic: https://issues.redhat.com/browse/NE-1299

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[alebedev87]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alebedev87]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@gcs278: This pull request references NE-1323 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

By adding a default value to the spec.provider.aws.credentials field, it enables the configuration of spec.provider.aws.assumeRole for an OpenShift user that doesn't need to explicitly specify the credentials field. Otherwise, an OpenShift user must manually insert "" as the credentials name to use the assumeRole field.

This improves user experience for the current v1beta1 release of ExternalDNS Operator while not introducing any breaking changes to the API. We are planning to properly fix this issue in a future ExternalDNS Operator API version by converting Credentials to an optional pointer.

Epic: https://issues.redhat.com/browse/NE-1299

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gcs278]

Going to put a hold on this while we get approval from docs, px, and qe and finish up enhancement review.
/hold

[openshift-ci-robot]

@gcs278: This pull request references NE-1323 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

By adding a default value to the spec.provider.aws.credentials field, it enables the configuration of spec.provider.aws.assumeRole for an OpenShift user that doesn't need to explicitly specify the credentials field. Otherwise, an OpenShift user must manually insert "" as the credentials name to use the assumeRole field.

This improves user experience for the current v1beta1 release of ExternalDNS Operator while not introducing any breaking changes to the API. We are planning to properly fix this issue in a future ExternalDNS Operator API version by converting Credentials to an optional pointer.

Epic: https://issues.redhat.com/browse/NE-1299

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ahardin-rh]

/label docs-approved

[melvinjoseph86]

/label qe-approved

[openshift-ci-robot]

@gcs278: This pull request references NE-1323 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

By adding a default value to the spec.provider.aws.credentials field, it enables the configuration of spec.provider.aws.assumeRole for an OpenShift user that doesn't need to explicitly specify the credentials field. Otherwise, an OpenShift user must manually insert "" as the credentials name to use the assumeRole field.

This improves user experience for the current v1beta1 release of ExternalDNS Operator while not introducing any breaking changes to the API. We are planning to properly fix this issue in a future ExternalDNS Operator API version by converting Credentials to an optional pointer.

Epic: https://issues.redhat.com/browse/NE-1299

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gcs278]

/unhold
We have approval on openshift/enhancements#1436 (minus some minor comments) so I am proceeding with the implementation PRs.
CC: @Miciah

[CFields651]

/label px-approved