Skip to content

Commit

Permalink
NE-1323: Add default to AWS credentials field
Browse files Browse the repository at this point in the history
By adding a default value to the spec.provider.aws.credentials field,
it enables the configuration of spec.provider.aws.assumeRole for an
OpenShift user that doesn't need to explicitly specify the credentials
field. Otherwise, an OpenShift user must manually insert "" as the
credentials name to use the assumeRole field.
  • Loading branch information
gcs278 committed Sep 28, 2023
1 parent 4cb22f1 commit ecc4cbe
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion api/v1beta1/externaldns_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ type ExternalDNSAWSProviderOptions struct {
// for more information.
//
// +kubebuilder:validation:Required
// +kubebuilder:default:={"name":""}
// +required
Credentials SecretReference `json:"credentials"`

Expand Down Expand Up @@ -491,7 +492,7 @@ const (
)

type ExternalDNSAWSAssumeRoleOptions struct {
// arn is an AWS role ARN that the ExternalDNS
// arn is an IAM role ARN that the ExternalDNS
// operator will assume when making DNS updates.
//
// +kubebuilder:validation:Required
Expand Down

0 comments on commit ecc4cbe

Please sign in to comment.