Use tagged image 4.1 instead of latest

[pavolloffay]

The latest image in 4.1 branch does not work. The branch should be using 4.1 tag instead.

https://quay.io/repository/openshift/origin-elasticsearch-operator?tab=tags

Signed-off-by: Pavol Loffay [email protected]

[openshift-ci-robot]

@pavolloffay: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Use tagged image 4.1 instead of latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

Hi @pavolloffay. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pavolloffay
To complete the pull request process, please assign ewolinetz
You can assign the PR to them by writing /assign @ewolinetz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ewolinetz]

/ok-to-test

[ewolinetz]

/assign ewolinetz

[bparees]

this is going to be problematic to maintain. especially since we can't change the 4.2 code to say "4.2" currently, since (i assume) the 4.2 tag doesn't exist yet.

So as soon as 4.2 ships, you're going to want to make the equivalent change in release-4.2, and so on.

Can we do something better here?

Note that the CSV doesn't even(should not anyway?) get published w/ this value in place....it is substituted by our ART pipeline logic. So what is motivating this PR?

[pavolloffay]

@bparees Could you please better describe why is it hard to maintain?
btw. 4.2 tag seems to be already published https://quay.io/repository/openshift/origin-elasticsearch-operator?tab=tags.

[bparees]

@bparees Could you please better describe why is it hard to maintain?

someone needs to remember to go bump this line every release. Inevitably it will be forgotten and anyone using this file directly will get the "wrong" image.

In fact i would prefer that this image field be a completely invalid value, to ensure no one is using this file directly and that anyone consuming it is explicitly configuring the image they want to use (or is getting the operator image from one of our pipelines that will have properly substituted the image value into this file).

[pavolloffay]

someone needs to remember to go bump this line every release. Inevitably it will be forgotten and anyone using this file directly will get the "wrong" image.

This change is only in release-4.1 branch and the used tag is 4.1. Do you think this branch will support other versions than 4.1?

someone needs to remember to go bump this line every release. Inevitably it will be forgotten and anyone using this file directly will get the "wrong" image.

right now anyone using this image get "wrong" image.

[bparees]

This change is only in release-4.1 branch and the used tag is 4.1. Do you think this branch will support other versions than 4.1?

you're going to have to make the same change in release-4.2, and then release-4.3, and then release-4.4, etc, each time we do a release.

right now anyone using this image get "wrong" image.

Hence my suggestion that this field should have a totally invalid value, to force people to specify the correct value. (again we wouldn't put it in users hands in that form, we do the substitution before we ship it, but it would ensure no one doing CI testing and such would be using the wrong thing).