STOR-1020: Rebase csi-node-driver-registrar to v2.7.0 for OCP 4.13
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a simple change that allows the registrar to be built for MacOS. All of the `unix` package being used works for Mac as well. The reason for enabling this is completely selfish I'll admit. We are adding [CSI Support](krustlet/krustlet#462) to the Krustlet project, which supports Mac as well. As most CSI implementations don't support registering themselves with the Kubelet directly, we wanted to unblock any users to need to register their plugins with a Krustlet Kubelet. This change shouldn't affect normal container-based usage of the registrar
kubernetes-csi/csi-release-tools@335339f0 Merge kubernetes-csi/csi-release-tools#187 from mauriciopoppe/remove-eol-windows-versions kubernetes-csi/csi-release-tools@890b87a2 Merge kubernetes-csi/csi-release-tools#188 from pwschuurman/update-release-notes-docs kubernetes-csi/csi-release-tools@274bc9ba Update Sidecar Release Process documentation to reference latest syntax for release-notes tool kubernetes-csi/csi-release-tools@87b6c372 Merge kubernetes-csi/csi-release-tools#185 from Garima-Negi/fix-OWNERS-files kubernetes-csi/csi-release-tools@f1de2c66 Fix OWNERS file - squashed commits kubernetes-csi/csi-release-tools@59ae38b7 Remove EOL windows versions from BUILD_PLATFORMS kubernetes-csi/csi-release-tools@5d664712 Merge kubernetes-csi/csi-release-tools#186 from humblec/sp kubernetes-csi/csi-release-tools@d066f1ba Correct prow.sh typo and make codespell linter pass kubernetes-csi/csi-release-tools@762e22d0 Merge kubernetes-csi/csi-release-tools#184 from pohly/image-publishing-troubleshooting kubernetes-csi/csi-release-tools@81e26c3f SIDECAR_RELEASE_PROCESS.md: add troubleshooting for image publishing git-subtree-dir: release-tools git-subtree-split: 335339f059da0b8b1947794a8c75d9e5b973cb79
master: update release-tools
kubernetes-csi/csi-release-tools@37d11049 Merge kubernetes-csi/csi-release-tools#191 from pohly/go-1.18 kubernetes-csi/csi-release-tools@db917f5c update to Go 1.18 git-subtree-dir: release-tools git-subtree-split: 37d1104926b30aa0544abb5a16c980ba82aaa585
master: update release-tools
Bump prometheus/client_golang to v1.11.1
Signed-off-by: Humble Chirammal <[email protected]>
update client-go,kubelet dependency to v1.24.0
Signed-off-by: Taylor Thomas <[email protected]>
…rt_mac feat(util): Allows building for darwin targets
kubernetes-csi/csi-release-tools@e4dab7ff Merge kubernetes-csi/csi-release-tools#194 from yselkowitz/registry-k8s-io kubernetes-csi/csi-release-tools@84a4d5a1 Move from k8s.gcr.io to registry.k8s.io git-subtree-dir: release-tools git-subtree-split: e4dab7ff57c24cf3e8d37cd3365636fddaff7e0a
master: update release-tools
Validate OWNERS files
kubernetes-csi/csi-release-tools@d29a2e75 Merge kubernetes-csi/csi-release-tools#198 from pohly/csi-test-5.0.0 kubernetes-csi/csi-release-tools@41cb70d3 prow.sh: sanity testing with csi-test v5.0.0 kubernetes-csi/csi-release-tools@c85a63fb Merge kubernetes-csi/csi-release-tools#197 from pohly/fix-alpha-testing kubernetes-csi/csi-release-tools@b86d8e94 support Kubernetes 1.25 + Ginkgo v2 kubernetes-csi/csi-release-tools@ab0b0a3d Merge kubernetes-csi/csi-release-tools#192 from andyzhangx/patch-1 kubernetes-csi/csi-release-tools@7bbab24e Merge kubernetes-csi/csi-release-tools#196 from humblec/non-alpha kubernetes-csi/csi-release-tools@e51ff2cc introduce control variable for non alpha feature gate configuration kubernetes-csi/csi-release-tools@ca19ef52 Merge kubernetes-csi/csi-release-tools#195 from pohly/fix-alpha-testing kubernetes-csi/csi-release-tools@3948331e fix testing with latest Kubernetes kubernetes-csi/csi-release-tools@9a0260c5 fix boilerplate header git-subtree-dir: release-tools git-subtree-split: d29a2e7547822371ebf3e61f7d2249c244879f85
master: update release-tools
Remove mkdir call while creating the registration probe file
…elease-tools-0823
d24254f6 Merge pull request kubernetes-csi#202 from xing-yang/kind_0.14.0 0faa3fc7 Update to Kind v0.14.0 images ef4e1b2b Merge pull request kubernetes-csi#201 from xing-yang/add_1.24_image 4ddce251 Add 1.24 Kind image 7fe51491 Merge pull request kubernetes-csi#200 from pohly/bump-kubernetes-version 70915a8e prow.sh: update snapshotter version 31a3f38b Merge pull request kubernetes-csi#199 from pohly/bump-kubernetes-version 7577454a prow.sh: bump Kubernetes to v1.22.0 git-subtree-dir: release-tools git-subtree-split: d24254f6aa780bb6ba36a946973ee01df5633f6b
…ools-0823 Update release tools
Signed-off-by: Humble Chirammal <[email protected]>
Do not print success log when error appears
…update-master Update dependency go modules for k8s v1.26.0
…update-master Upgrade csi-lib-utils to v0.12.0
Add CHANGELOG-2.7md for k8s 1.26.0 release
openshift-ci-robot
added
the
jira/valid-reference
|
@mpatlasov: This pull request references STOR-1020 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label docs-approved |
openshift-ci
bot
added
docs-approved
|
/retest-required |
mpatlasov
force-pushed
the
rebase-2.7.0
branch
from
c4dc5aa to
75aa306
Compare
|
/retest |
|
I think |
And remove .github
mpatlasov
force-pushed
the
rebase-2.7.0
branch
from
75aa306 to
b825645
Compare
|
@mpatlasov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, mpatlasov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Checked the CI results look good for sidecar rebase. |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff to upstream v2.7.0:
kubernetes-csi/node-driver-registrar@v2.7.0...mpatlasov:rebase-2.7.0
Major changes between 2.5.1 (OCP 4.12) and 2.7.0:
Revert of kubernetes-csi#214, node-driver-registrar will create the path specified by --kubelet-registration-path (kubernetes-csi#247, @mauriciopoppe)
Full changelogs:
https://github.com/kubernetes-csi/node-driver-registrar/releases/tag/v2.7.0
@openshift/storage