Remove mkdir call while creating the registration probe file #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
mauriciopoppe
force-pushed
the
remove-mkdirall
branch
from
e8ed512 to
2d19977
Compare
msau42
reviewed
Aug 11, 2022
| @@ -88,11 +87,6 @@ func TouchFile(filePath string) error { | |||
| return err | |||
| } | |||
| if !exists { | |||
| err := os.MkdirAll(filepath.Dir(filePath), 0755) | |||
There was a problem hiding this comment.
Is this assumption true for all csi drivers?
There was a problem hiding this comment.
The path for the temp registration file is hidden from the users, the steps to create it are:
- take the kubelet registration path:
/var/lib/kubelet/plugins/<drivername.example.com>/csi.sock - on a successful registration, write the temp file to the same dirname:
/var/lib/kubelet/plugins/<drivername.example.com>/registration
I think the directory /var/lib/kubelet/plugins/<drivername.example.com>/ is created in advance in the driver spec e.g. from the README
volumes:
- name: plugin-dir
hostPath:
path: /var/lib/kubelet/plugins/<drivername.example.com>/
type: DirectoryOrCreate
I checked a few drivers:
I think the assumption that this directory is created is true therefore node-driver-registrar should only create the file assuming that the dir already exists
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mauriciopoppe, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Nov 17, 2022
sunnylovestiramisu
added a commit
to sunnylovestiramisu/node-driver-registrar
that referenced
this pull request
Apr 12, 2023
6613c398 Merge pull request kubernetes-csi#223 from sunnylovestiramisu/update 0e7ae993 Update k8s image repo url 77e47cce Merge pull request kubernetes-csi#222 from xinydev/fix-dep-version 155854b0 Fix dep version mismatch 8f839056 Merge pull request kubernetes-csi#221 from sunnylovestiramisu/go-update 1d3f94dd Update go version to 1.20 to match k/k v1.27 e322ce5e Merge pull request kubernetes-csi#220 from andyzhangx/fix-golint-error b74a5120 test: fix golint error aa61bfd0 Merge pull request kubernetes-csi#218 from xing-yang/update_csi_driver 7563d196 Update CSI_PROW_DRIVER_VERSION to v1.11.0 a2171bef Merge pull request kubernetes-csi#216 from msau42/process cb987826 Merge pull request kubernetes-csi#217 from msau42/owners a11216e4 add new reviewers and remove inactive reviewers dd986754 Add step for checking builds b66c0824 Merge pull request kubernetes-csi#214 from pohly/junit-fixes b9b6763b filter-junit.go: fix loss of testcases when parsing Ginkgo v2 JUnit d4277839 filter-junit.go: preserve system error log 38e11468 prow.sh: publish individual JUnit files as separate artifacts git-subtree-dir: release-tools git-subtree-split: 6613c3980d1e418bebb7bc49d64c977cfff85671
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
node-driver-registrar fails to come up on a filesystem where the
/var/lib/kubeletdirectory is read onlyUnder the assumption that the
kubeletRegistrationPathpath exists we don't need to create subdirectories, we will still create the probe exec file by default though.Which issue(s) this PR fixes:
Fixes #213
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/cc @jingxu97 @msau42