STOR-1743: Adapt e2e tests for OCP

[Phaow]

STOR-1743: Adapt e2e tests for OCP

• Use the samba server configuration consist with our storage-create-csi-smb-ref CI step
• Fix the nil pointer issue of the smbDriver
• Update several cases mountoption since previous upstream default smb server use the PERMISSIONS: "0777" while our samba server does not use the server configuration

Test records

version: smb-csi-driver-operator.v4.16.0-202404231239

• All e2e test (also temporarily comment skipped one should create a volume after driver restart [smb.csi.k8s.io] which has disruptive option)

$ go test -v -timeout=0 ./test/e2e -ginkgo.v -ginkgo.timeout=2h
------------------------------

Ran 12 of 12 Specs in 367.355 seconds
SUCCESS! -- 12 Passed | 0 Failed | 0 Pending | 0 Skipped
You're using deprecated Ginkgo functionality:
=============================================
  Support for custom reporters has been removed in V2.  Please read the documentation linked to below for Ginkgo's new behavior and for a migration path:
  Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=2.13.0

--- PASS: TestE2E (367.36s)
PASS
ok      github.com/kubernetes-csi/csi-driver-smb/test/e2e       368.770s

• All e2e test

$ go test -v -timeout=0 ./test/e2e -ginkgo.v -ginkgo.timeout=2h
------------------------------

Ran 11 of 12 Specs in 284.809 seconds
SUCCESS! -- 11 Passed | 0 Failed | 0 Pending | 1 Skipped
You're using deprecated Ginkgo functionality:
=============================================
  Support for custom reporters has been removed in V2.  Please read the documentation linked to below for Ginkgo's new behavior and for a migration path:
  Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=2.13.0

--- PASS: TestE2E (284.81s)
PASS
ok      github.com/kubernetes-csi/csi-driver-smb/test/e2e       286.295s

[openshift-ci-robot]

@Phaow: This pull request references STOR-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

STOR-1743: Adapt e2e tests for OCP

• Use the samba server configuration consist with our storage-create-csi-smb-ref CI step
• Fix the nil pointer issue of the smbDriver
• Update several cases mountoption since previous upstream default smb server use the PERMISSIONS: "0777" while our samba server does not use the server configuration

Test records

version: smb-csi-driver-operator.v4.16.0-202404231239

• All e2e test (also temporarily comment skipped one should create a volume after driver restart [smb.csi.k8s.io] which has disruptive option)

$ go test -v -timeout=0 ./test/e2e -ginkgo.v -ginkgo.timeout=2h
------------------------------

Ran 12 of 12 Specs in 367.355 seconds
SUCCESS! -- 12 Passed | 0 Failed | 0 Pending | 0 Skipped
You're using deprecated Ginkgo functionality:
=============================================
 Support for custom reporters has been removed in V2.  Please read the documentation linked to below for Ginkgo's new behavior and for a migration path:
 Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
 ACK_GINKGO_DEPRECATIONS=2.13.0

--- PASS: TestE2E (367.36s)
PASS
ok      github.com/kubernetes-csi/csi-driver-smb/test/e2e       368.770s

• All e2e test

$ go test -v -timeout=0 ./test/e2e -ginkgo.v -ginkgo.timeout=2h
------------------------------

Ran 11 of 12 Specs in 284.809 seconds
SUCCESS! -- 11 Passed | 0 Failed | 0 Pending | 1 Skipped
You're using deprecated Ginkgo functionality:
=============================================
 Support for custom reporters has been removed in V2.  Please read the documentation linked to below for Ginkgo's new behavior and for a migration path:
 Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
 ACK_GINKGO_DEPRECATIONS=2.13.0

--- PASS: TestE2E (284.81s)
PASS
ok      github.com/kubernetes-csi/csi-driver-smb/test/e2e       286.295s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@Phaow: This pull request references STOR-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

STOR-1743: Adapt e2e tests for OCP

• Use the samba server configuration consist with our storage-create-csi-smb-ref CI step
• Fix the nil pointer issue of the smbDriver
• Update several cases mountoption since previous upstream default smb server use the PERMISSIONS: "0777" while our samba server does not use the server configuration

Test records

version: smb-csi-driver-operator.v4.16.0-202404231239

• All e2e test (also temporarily comment skipped one should create a volume after driver restart [smb.csi.k8s.io] which has disruptive option)

$ go test -v -timeout=0 ./test/e2e -ginkgo.v -ginkgo.timeout=2h
------------------------------

Ran 12 of 12 Specs in 367.355 seconds
SUCCESS! -- 12 Passed | 0 Failed | 0 Pending | 0 Skipped
You're using deprecated Ginkgo functionality:
=============================================
 Support for custom reporters has been removed in V2.  Please read the documentation linked to below for Ginkgo's new behavior and for a migration path:
 Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
 ACK_GINKGO_DEPRECATIONS=2.13.0

--- PASS: TestE2E (367.36s)
PASS
ok      github.com/kubernetes-csi/csi-driver-smb/test/e2e       368.770s

• All e2e test

$ go test -v -timeout=0 ./test/e2e -ginkgo.v -ginkgo.timeout=2h
------------------------------

Ran 11 of 12 Specs in 284.809 seconds
SUCCESS! -- 11 Passed | 0 Failed | 0 Pending | 1 Skipped
You're using deprecated Ginkgo functionality:
=============================================
 Support for custom reporters has been removed in V2.  Please read the documentation linked to below for Ginkgo's new behavior and for a migration path:
 Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
 ACK_GINKGO_DEPRECATIONS=2.13.0

--- PASS: TestE2E (284.81s)
PASS
ok      github.com/kubernetes-csi/csi-driver-smb/test/e2e       286.295s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Phaow]

Hi @jsafrane @mpatlasov , could you please help take a look when you get a chance? Thanks!

[Phaow]

/hold
Try with use env var for smb server configuration and filed PR in upstream.
kubernetes-csi#773

[openshift-ci]

@Phaow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	2d41f5d	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Phaow]

/hold cancel

[Phaow]

cherry-pick the upstream commit and retest passed.

$ export CSI_DRIVER_INSTALLED_NAMESPACE="openshift-cluster-csi-drivers"
$ export TEST_SMB_SOURCE="//samba-server.samba-server.svc.cluster.local/share"
$ export TEST_SMB_SECRET_NAME="smbcreds"
$ export TEST_SMB_SECRET_NAMESPACE="samba-server"
$ go test -v -timeout=0 ./test/e2e -ginkgo.v -ginkgo.timeout=2h
...
------------------------------

Ran 11 of 12 Specs in 299.753 seconds
SUCCESS! -- 11 Passed | 0 Failed | 0 Pending | 1 Skipped
You're using deprecated Ginkgo functionality:
=============================================
  Support for custom reporters has been removed in V2.  Please read the documentation linked to below for Ginkgo's new behavior and for a migration path:
  Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=2.13.0

--- PASS: TestE2E (299.75s)
PASS
ok      github.com/kubernetes-csi/csi-driver-smb/test/e2e       300.509s

Hi @jsafrane @mpatlasov , could you please help take a look when you get a chance? Thanks!

[mpatlasov]

/lgtm
/approve
/label docs-approved
/label px-approved

Thank you, @Phaow !

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov, Phaow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mpatlasov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Phaow]

/label qe-approved

[openshift-ci-robot]

@Phaow: This pull request references STOR-1743 which is a valid jira issue.

In response to this:

STOR-1743: Adapt e2e tests for OCP

• Use the samba server configuration consist with our storage-create-csi-smb-ref CI step
• Fix the nil pointer issue of the smbDriver
• Update several cases mountoption since previous upstream default smb server use the PERMISSIONS: "0777" while our samba server does not use the server configuration

Test records

version: smb-csi-driver-operator.v4.16.0-202404231239

• All e2e test (also temporarily comment skipped one should create a volume after driver restart [smb.csi.k8s.io] which has disruptive option)

$ go test -v -timeout=0 ./test/e2e -ginkgo.v -ginkgo.timeout=2h
------------------------------

Ran 12 of 12 Specs in 367.355 seconds
SUCCESS! -- 12 Passed | 0 Failed | 0 Pending | 0 Skipped
You're using deprecated Ginkgo functionality:
=============================================
 Support for custom reporters has been removed in V2.  Please read the documentation linked to below for Ginkgo's new behavior and for a migration path:
 Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
 ACK_GINKGO_DEPRECATIONS=2.13.0

--- PASS: TestE2E (367.36s)
PASS
ok      github.com/kubernetes-csi/csi-driver-smb/test/e2e       368.770s

• All e2e test

$ go test -v -timeout=0 ./test/e2e -ginkgo.v -ginkgo.timeout=2h
------------------------------

Ran 11 of 12 Specs in 284.809 seconds
SUCCESS! -- 11 Passed | 0 Failed | 0 Pending | 1 Skipped
You're using deprecated Ginkgo functionality:
=============================================
 Support for custom reporters has been removed in V2.  Please read the documentation linked to below for Ginkgo's new behavior and for a migration path:
 Learn more at: https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
 ACK_GINKGO_DEPRECATIONS=2.13.0

--- PASS: TestE2E (284.81s)
PASS
ok      github.com/kubernetes-csi/csi-driver-smb/test/e2e       286.295s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-smb-csi-driver-container-v4.16.0-202405100946.p0.gff97707.assembly.stream.el9 for distgit ose-smb-csi-driver.
All builds following this will include this PR.