-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: use env var for smb server configuration #773
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @Phaow! |
Hi @Phaow. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @andyzhangx , could you please help take a look when you get a chance? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Pull Request Test Coverage Report for Build 8977925603Details
💛 - Coveralls |
/retest |
/test pull-csi-driver-smb-sanity |
/retest-required |
1 similar comment
/retest-required |
/test pull-csi-driver-smb-sanity |
It's a bit strange, I could execute the $ make sanity-test
------------------------------
Ran 37 of 78 Specs in 4.751 seconds
SUCCESS! -- 37 Passed | 0 Failed | 1 Pending | 40 Skipped
pkill -f smbplugin
Deleting CSI sanity test binary
Uninstalling samba server on localhost
samba |
/retest |
1 similar comment
/retest |
/test pull-csi-driver-smb-sanity |
@Phaow: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, Phaow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
test: use env var for smb server configuration
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: