Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use env var for smb server configuration #773

Merged
merged 1 commit into from
May 8, 2024

Conversation

Phaow
Copy link
Contributor

@Phaow Phaow commented May 7, 2024

What type of PR is this?
/kind failing-test

What this PR does / why we need it:

  • Fixed run the e2e test locally the smbDriver nil pointer issue
  • Use env var for smb server configuration to make e2e test execute in different test clusters more flexibility.
  • Use obvious mountOption in case to make e2e test could be executed in some different smb server configurations

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels May 7, 2024
Copy link

linux-foundation-easycla bot commented May 7, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 7, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Phaow!

It looks like this is your first PR to kubernetes-csi/csi-driver-smb 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-smb has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Phaow. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 7, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 7, 2024
@Phaow
Copy link
Contributor Author

Phaow commented May 7, 2024

Hi @andyzhangx , could you please help take a look when you get a chance? Thank you!

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8977925603

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.293%

Totals Coverage Status
Change from base Build 8832986014: 0.0%
Covered Lines: 942
Relevant Lines: 1188

💛 - Coveralls

@andyzhangx
Copy link
Member

/retest

@Phaow
Copy link
Contributor Author

Phaow commented May 7, 2024

/test pull-csi-driver-smb-sanity

@Phaow
Copy link
Contributor Author

Phaow commented May 7, 2024

/retest-required

1 similar comment
@Phaow
Copy link
Contributor Author

Phaow commented May 7, 2024

/retest-required

@Phaow
Copy link
Contributor Author

Phaow commented May 7, 2024

/test pull-csi-driver-smb-sanity

@Phaow
Copy link
Contributor Author

Phaow commented May 7, 2024

It's a bit strange, I could execute the sanity-test on my local successfully. In the failure job logs always failed to get metrics: failed to get FsInfo due to error resource temporarily unavailable. The PR does not modify any driver itself codes should have no influence with the sanity-test results. @andyzhangx Do you happen to know something about this? Is there I missed something?

$ make sanity-test
------------------------------

Ran 37 of 78 Specs in 4.751 seconds
SUCCESS! -- 37 Passed | 0 Failed | 1 Pending | 40 Skipped
pkill -f smbplugin
Deleting CSI sanity test binary
Uninstalling samba server on localhost
samba

@andyzhangx
Copy link
Member

/retest

1 similar comment
@Phaow
Copy link
Contributor Author

Phaow commented May 7, 2024

/retest

@Phaow
Copy link
Contributor Author

Phaow commented May 8, 2024

/test pull-csi-driver-smb-sanity

@k8s-ci-robot
Copy link
Contributor

@Phaow: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-csi-driver-smb-sanity 6e93ede link true /test pull-csi-driver-smb-sanity

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, Phaow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2024
@andyzhangx andyzhangx merged commit 6f73280 into kubernetes-csi:master May 8, 2024
19 of 21 checks passed
Phaow pushed a commit to Phaow/csi-driver-smb that referenced this pull request May 8, 2024
test: use env var for smb server configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants