NE-581: Rebase to upstream v1.8.4 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris O'Haver <[email protected]>
…ve. (coredns#4396) Signed-off-by: Frank Riley <[email protected]>
Automatically submitted.
Automatically submitted.
Fixes coredns#4428 Signed-off-by: Lars Ekman <[email protected]>
Signed-off-by: timyinshi <[email protected]>
…coredns#4391) * plugin/forward Add rcode and rtype to request_duration_seconds metric Signed-off-by: Maxime Ginters <[email protected]> * Control the cardinality of query type Signed-off-by: Maxime Ginters <[email protected]>
Traces are currently working properly with datadog with the exception of having the ability to facet the tags  In order to get valuable graph in dashboard the tag on the metrics need to be faceted by datadog. This PR update the tags with facetable path. While keeping backward compatibility with existing path for zipkin. Graph like:      Signed-off-by: bob <[email protected]>
* Revert "make copies of RRs before returning them (coredns#4409)" This reverts commit 8b2ff6c. * Document copying responses See coredns#4409 and the comments. This documents that issue, but doesn't change the in-tree plugins just yet. Signed-off-by: Miek Gieben <[email protected]> * Update plugin.md Co-authored-by: Chris O'Haver <[email protected]> Co-authored-by: Chris O'Haver <[email protected]>
…#4421) This commit replaces `manifest-tool` with `docker manifest`, which should hopefully provide a better experience for releasing coredns. In addition it integrates mips64le (since it's supported by `docker manifest`) in LINUX_ARCHES, so docker images for mips64le are pushed as well. Signed-off-by: Manuel Rüger <[email protected]>
…oredns#4441) Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.36.31 to 1.37.1. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.36.31...v1.37.1) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
…#4442) Bumps [github.com/miekg/dns](https://github.com/miekg/dns) from 1.1.35 to 1.1.37. - [Release notes](https://github.com/miekg/dns/releases) - [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release) - [Commits](miekg/dns@v1.1.35...v1.1.37) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Currently ACLs only allow for allow and block, however it isn't always desirable to set the status code to REFUSED. Often times you want to completely hide the fact that those records even exist. Adding the ability to acl to filter results makes it significantly harder for a third party to know that the records are being masked. Signed-off-by: George Shammas <[email protected]>
Copy the msg to prevent messing with the (via the pointer) original created message that may be stored in the cache or anything other data store. Signed-off-by: Miek Gieben <[email protected]>
* plugin/transfer: only allow outgoing axfr over tcp Return refused when the query comes in over udp. No need to add a new test case as the current crop needed to be changed to use TCP. Fixes: coredns#4450 Signed-off-by: Miek Gieben <[email protected]> * transfer tests: this needs tcp as well Signed-off-by: Miek Gieben <[email protected]>
…s#4451) Signed-off-by: answer1991 <[email protected]>
* plugin/sign: track zone file's mtime Resign if the original zone's mtime is change in some way. Closes coredns#4407 Signed-off-by: Miek Gieben <[email protected]> * Update plugin/sign/README.md Co-authored-by: Chris O'Haver <[email protected]> Co-authored-by: Yong Tang <[email protected]> Co-authored-by: Chris O'Haver <[email protected]>
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test e2e-aws |
|
/refresh |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
Add sgreene70, frobware, candita, rfredette, and alebedev87 to the approvers section of the OWNERS file.
Add github.com/openshift/coredns-mdns Should be reevaluated next rebase
…image` from openshift/release This is an autogenerated PR that updates the `.ci-operator.yaml` to reference the `build_root_image` found in the [ci-operator-config](https://github.com/openshift/release/tree/master/ci-operator/config) in the [openshift/release](https://github.com/openshift/release) repository. This is done in preparation for enabling reading the `build_root` from your repository rather than the central config in [openshift/release](https://github.com/openshift/release). This allows to update the `build_root` in lockstep with code changes. For details, please refer to the [docs](https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). Note that enabling this feature is mandatory for all OCP components that have an ART build config. A second autogenerated PR to the [openshift/release repository](https://github.com/openshift/release) will enable reading the `build_root` from your repository once this PR was merged. If you have any questions, please feel free to reach out in the #forum-testplatform channel in the CoreOS Slack.
|
@rfredette: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfredette, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created following the same process as #52
Process:
where e769ec9 is the merge commit for the previous rebase
The resulting merge commit is 60ff4c4
Some commits that were local to this fork don't need to be kept in the rebase. All vendor/go.mod commits were squashed into one; several upstream commits that were manually ported to this fork are already in 1.8.4, so they were dropped.
The full list of dropped or squashed commits is:
The final list of commits that were kept is (cherry-picked from bottom to top):