make copies of RRs before returning them (coredns#4409)

Signed-off-by: Chris O'Haver <[email protected]>
rfredette · Jan 21, 2021 · 8b2ff6c · 8b2ff6c
1 parent 95622f4
commit 8b2ff6c
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/plugin/file/lookup.go b/plugin/file/lookup.go
@@ -171,7 +171,12 @@ func (z *Zone) Lookup(ctx context.Context, state request.Request, qname string)
 			return z.externalLookup(ctx, state, elem, rrs)
 		}
 
-		rrs := elem.Type(qtype)
+		treeRRs := elem.Type(qtype)
+		// make a copy of the element RRs to prevent response writers from mutating the tree
+		rrs := make([]dns.RR, len(treeRRs))
+		for i, rr := range treeRRs {
+			rrs[i] = dns.Copy(rr)
+		}
 
 		// NODATA
 		if len(rrs) == 0 {