Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33750: UPSTREAM: <carry>: openshift: Bump the version of ocp_dnsnameresolver external plugin #122

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

arkadeepsen
Copy link
Member

@arkadeepsen arkadeepsen commented Jun 5, 2024

This PR bumps the version of the external plugin ocp_dnsnameresolver
Following commands were run:

go get github.com/openshift/coredns-ocp-dnsnameresolver@latest
go mod tidy
go mod vendor

go generate

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 5, 2024
@openshift-ci-robot
Copy link

@arkadeepsen: This pull request references Jira Issue OCPBUGS-33750, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huiran0826

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR bumps the version of the external plugin ocp_dnsnameresolver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 5, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2024
Copy link

openshift-ci bot commented Jun 5, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: huiran0826.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@arkadeepsen: This pull request references Jira Issue OCPBUGS-33750, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @huiran0826

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR bumps the version of the external plugin ocp_dnsnameresolver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from alebedev87 and gcs278 June 5, 2024 06:30
@arkadeepsen
Copy link
Member Author

Depends on openshift/coredns-ocp-dnsnameresolver#8

@arkadeepsen arkadeepsen changed the title [WIP] OCPBUGS-33750: UPSTREAM: <carry>: openshift: Bump the version of ocp_dnsnameresolver external plugin OCPBUGS-33750: UPSTREAM: <carry>: openshift: Bump the version of ocp_dnsnameresolver external plugin Jul 12, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2024
Copy link

openshift-ci bot commented Jul 12, 2024

@arkadeepsen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@arkadeepsen
Copy link
Member Author

/assign @alebedev87

@alebedev87
Copy link

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024
Copy link

openshift-ci bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d95440d into openshift:master Jul 22, 2024
7 checks passed
@openshift-ci-robot
Copy link

@arkadeepsen: Jira Issue OCPBUGS-33750: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-33750 has not been moved to the MODIFIED state.

In response to this:

This PR bumps the version of the external plugin ocp_dnsnameresolver
Following commands were run:

go get github.com/openshift/coredns-ocp-dnsnameresolver@latest
go mod tidy
go mod vendor

go generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: coredns
This PR has been included in build coredns-container-v4.17.0-202407221718.p0.gd95440d.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants