OCPBUGS-33750: Bump version of DNSNameResolver controller #415
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/severity-important
|
@arkadeepsen: This pull request references Jira Issue OCPBUGS-33750, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Depends on openshift/coredns-ocp-dnsnameresolver#8 |
arkadeepsen
force-pushed
the
dnsnameresolver-controller
branch
from
b98c8a1 to
bc00361
Compare
arkadeepsen
force-pushed
the
dnsnameresolver-controller
branch
from
bc00361 to
05c8a76
Compare
arkadeepsen
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/test ? |
|
@arkadeepsen: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @alebedev87 |
|
For |
|
/lgtm |
|
/lgtm cancel |
| }) | ||
| cr.Rules = append(cr.Rules, rbacv1.PolicyRule{ | ||
| APIGroups: []string{"network.openshift.io"}, | ||
| Resources: []string{"dnsnameresolvers/status"}, | ||
| Verbs: []string{"update"}, | ||
| Verbs: []string{"get", "update", "patch"}, |
There was a problem hiding this comment.
So this is the update related to the new get we do in the plugin. However I'm wondering whether the patch verb comes from.
There was a problem hiding this comment.
It was during the implementation phase when you had suggested to add get, update and patch verbs for the status subresource based on kubebuilder's suggestion. That's why I added patch as well in the list.
|
/lgtm |
|
/test e2e-aws-ovn-techpreview |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@arkadeepsen: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@arkadeepsen: Jira Issue OCPBUGS-33750: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-33750 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-dns-operator |
This PR bumps the version of the the DNSNameResolver controller. This PR also adds the additional RBAC permissions required by the CoreDNS pods for the DNSNameResolver CRs.