-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.14] OCPBUGS-19623: multus: set MULTUS_NODE_NAME to filter pods to local node #2022
[release-4.14] OCPBUGS-19623: multus: set MULTUS_NODE_NAME to filter pods to local node #2022
Conversation
This allows multus to set an apiserver filter to only watch pods on its own node. Should reduce memory usage as multus doesn't care about pods on other nodes. Clusters with ~60,000 pods show multus using around 1.8G of RSS which seems fairly unecessary.
@openshift-cherrypick-robot: Jira Issue OCPBUGS-19550 has been cloned as Jira Issue OCPBUGS-19623. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19623, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19623, which is valid. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, kyrtapz, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/test e2e-aws-ovn-network-migration |
/retest-required |
/label cherry-pick-approved |
@openshift-cherrypick-robot: Jira Issue OCPBUGS-19623: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-19623 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fix included in accepted release 4.14.0-0.nightly-2023-09-23-035947 |
This is an automated cherry-pick of #2020
Resolves apiserver and worker node CPU/memory regression after openshift/multus-cni#181 landed by adding a piece that was forgotten in #1990