Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-19550: multus: set MULTUS_NODE_NAME to filter pods to local node #2020

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

dcbw
Copy link
Contributor

@dcbw dcbw commented Sep 21, 2023

This allows multus to set an apiserver filter to only watch pods on its own node. Should reduce memory usage as multus doesn't care about pods on other nodes.

Clusters with ~60,000 pods show multus using around 1.8G of RSS which seems fairly unnecessary.

QE: can be verified by looking at the top of kube-multus container logs in multus pods:

$ oc logs -n openshift-multus -c kube-multus multus-llgcj | grep "Filtering pod"
2023-09-21T12:44:11Z [verbose] Filtering pod watch for node "ci-op-fvc0qy12-b3a20-dkw5b-worker-b-m7qmq"

This allows multus to set an apiserver filter to only watch pods
on its own node. Should reduce memory usage as multus doesn't
care about pods on other nodes.

Clusters with ~60,000 pods show multus using around 1.8G of RSS
which seems fairly unecessary.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
@dcbw dcbw changed the title multus: set MULTUS_NODE_NAME to filter pods to local node OCPBUGS-19550: multus: set MULTUS_NODE_NAME to filter pods to local node Sep 21, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 21, 2023
@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Jira Issue OCPBUGS-19550, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This allows multus to set an apiserver filter to only watch pods on its own node. Should reduce memory usage as multus doesn't care about pods on other nodes.

Clusters with ~60,000 pods show multus using around 1.8G of RSS which seems fairly unecessary.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 21, 2023
@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Jira Issue OCPBUGS-19550, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

This allows multus to set an apiserver filter to only watch pods on its own node. Should reduce memory usage as multus doesn't care about pods on other nodes.

Clusters with ~60,000 pods show multus using around 1.8G of RSS which seems fairly unnecessary.

QE: can be verified by looking at the top of kube-multus container logs in multus pods for the line:

2023-09-21T12:44:11Z [verbose] Filtering pod watch for node "ci-op-fvc0qy12-b3a20-dkw5b-worker-b-m7qmq"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor Author

dcbw commented Sep 21, 2023

/test qe-perfscale-aws-ovn-cluster-density

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

@dcbw: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test 4.14-upgrade-from-stable-4.13-images
  • /test e2e-aws-ovn-network-migration
  • /test e2e-aws-ovn-windows
  • /test e2e-aws-sdn-multi
  • /test e2e-aws-sdn-network-migration-rollback
  • /test e2e-aws-sdn-network-reverse-migration
  • /test e2e-gcp-ovn
  • /test e2e-gcp-sdn
  • /test e2e-hypershift-ovn
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-vsphere-ovn-windows
  • /test images
  • /test lint
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test 4.14-upgrade-from-stable-4.13-e2e-aws-ovn-upgrade
  • /test 4.14-upgrade-from-stable-4.13-e2e-azure-ovn-upgrade
  • /test 4.14-upgrade-from-stable-4.13-e2e-gcp-ovn-upgrade
  • /test e2e-aws-hypershift-ovn-kubevirt
  • /test e2e-aws-ovn-local-to-shared-gateway-mode-migration
  • /test e2e-aws-ovn-serial
  • /test e2e-aws-ovn-shared-to-local-gateway-mode-migration-periodic
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-sdn-upgrade
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-dualstack
  • /test e2e-azure-ovn-manual-oidc
  • /test e2e-gcp-ovn-upgrade
  • /test e2e-metal-ipi-ovn-ipv6-ipsec
  • /test e2e-network-mtu-migration-ovn-ipv4
  • /test e2e-network-mtu-migration-ovn-ipv6
  • /test e2e-network-mtu-migration-sdn-ipv4
  • /test e2e-openstack-kuryr
  • /test e2e-openstack-ovn
  • /test e2e-openstack-sdn
  • /test e2e-ovn-hybrid-step-registry
  • /test e2e-ovn-ipsec-step-registry
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-ovn-dualstack
  • /test qe-perfscale-aws-ovn-medium-cluster-density
  • /test qe-perfscale-aws-ovn-medium-node-density-cni
  • /test qe-perfscale-aws-ovn-small-cluster-density
  • /test qe-perfscale-aws-ovn-small-node-density-cni

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-network-operator-master-4.14-upgrade-from-stable-4.13-images
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-hypershift-ovn-kubevirt
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-serial
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-shared-to-local-gateway-mode-migration-periodic
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-windows
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-sdn-multi
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-sdn-network-migration-rollback
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-sdn-network-reverse-migration
  • pull-ci-openshift-cluster-network-operator-master-e2e-aws-sdn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-e2e-azure-ovn
  • pull-ci-openshift-cluster-network-operator-master-e2e-gcp-ovn
  • pull-ci-openshift-cluster-network-operator-master-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-cluster-network-operator-master-e2e-gcp-sdn
  • pull-ci-openshift-cluster-network-operator-master-e2e-hypershift-ovn
  • pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6
  • pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6-ipsec
  • pull-ci-openshift-cluster-network-operator-master-e2e-network-mtu-migration-ovn-ipv4
  • pull-ci-openshift-cluster-network-operator-master-e2e-network-mtu-migration-ovn-ipv6
  • pull-ci-openshift-cluster-network-operator-master-e2e-network-mtu-migration-sdn-ipv4
  • pull-ci-openshift-cluster-network-operator-master-e2e-openstack-ovn
  • pull-ci-openshift-cluster-network-operator-master-e2e-openstack-sdn
  • pull-ci-openshift-cluster-network-operator-master-e2e-ovn-hybrid-step-registry
  • pull-ci-openshift-cluster-network-operator-master-e2e-ovn-ipsec-step-registry
  • pull-ci-openshift-cluster-network-operator-master-e2e-ovn-step-registry
  • pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn
  • pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack
  • pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-windows
  • pull-ci-openshift-cluster-network-operator-master-images
  • pull-ci-openshift-cluster-network-operator-master-lint
  • pull-ci-openshift-cluster-network-operator-master-unit
  • pull-ci-openshift-cluster-network-operator-master-verify

In response to this:

/test qe-perfscale-aws-ovn-cluster-density

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor Author

dcbw commented Sep 21, 2023

/test qe-perfscale-aws-ovn-medium-cluster-density
/test qe-perfscale-aws-ovn-medium-node-density-cni

@kyrtapz
Copy link
Contributor

kyrtapz commented Sep 21, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6888ace and 2 for PR HEAD 59eb5c5 in total

@dcbw
Copy link
Contributor Author

dcbw commented Sep 21, 2023

/override ci/prow/e2e-aws-sdn-network-migration-rollback

registry timeouts

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-sdn-network-migration-rollback

In response to this:

/override ci/prow/e2e-aws-sdn-network-migration-rollback

registry timeouts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

@dcbw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/qe-perfscale-aws-ovn-medium-node-density-cni 59eb5c5 link false /test qe-perfscale-aws-ovn-medium-node-density-cni
ci/prow/e2e-vsphere-ovn 59eb5c5 link false /test e2e-vsphere-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec 59eb5c5 link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-ovn-ipsec-step-registry 59eb5c5 link false /test e2e-ovn-ipsec-step-registry
ci/prow/e2e-vsphere-ovn-dualstack 59eb5c5 link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-aws-ovn-single-node 59eb5c5 link false /test e2e-aws-ovn-single-node
ci/prow/qe-perfscale-aws-ovn-medium-cluster-density 59eb5c5 link false /test qe-perfscale-aws-ovn-medium-cluster-density
ci/prow/e2e-network-mtu-migration-ovn-ipv6 59eb5c5 link false /test e2e-network-mtu-migration-ovn-ipv6
ci/prow/e2e-network-mtu-migration-sdn-ipv4 59eb5c5 link false /test e2e-network-mtu-migration-sdn-ipv4
ci/prow/e2e-aws-hypershift-ovn-kubevirt 59eb5c5 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-network-mtu-migration-ovn-ipv4 59eb5c5 link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-gcp-ovn-upgrade 59eb5c5 link false /test e2e-gcp-ovn-upgrade
ci/prow/e2e-openstack-sdn 59eb5c5 link false /test e2e-openstack-sdn
ci/prow/e2e-openstack-ovn 59eb5c5 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-serial 59eb5c5 link false /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c097483 into openshift:master Sep 21, 2023
@openshift-ci-robot
Copy link
Contributor

@dcbw: Jira Issue OCPBUGS-19550: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-19550 has been moved to the MODIFIED state.

In response to this:

This allows multus to set an apiserver filter to only watch pods on its own node. Should reduce memory usage as multus doesn't care about pods on other nodes.

Clusters with ~60,000 pods show multus using around 1.8G of RSS which seems fairly unnecessary.

QE: can be verified by looking at the top of kube-multus container logs in multus pods:

$ oc logs -n openshift-multus -c kube-multus multus-llgcj | grep "Filtering pod"
2023-09-21T12:44:11Z [verbose] Filtering pod watch for node "ci-op-fvc0qy12-b3a20-dkw5b-worker-b-m7qmq"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor Author

dcbw commented Sep 21, 2023

/cherry-pick release-4.14

@openshift-cherrypick-robot

@dcbw: new pull request created: #2022

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants