Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] OCPBUGS-37078: Bump version of DNSNameResolver controller #419

Merged
merged 2 commits into from
Aug 7, 2024
Merged

[release-4.16] OCPBUGS-37078: Bump version of DNSNameResolver controller #419

merged 2 commits into from
Aug 7, 2024

Conversation

arkadeepsen
Copy link
Member

This PR bumps the version of the the DNSNameResolver controller for release-4.16. This PR also adds the additional RBAC permissions required by the CoreDNS pods for the DNSNameResolver CRs.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 31, 2024
@openshift-ci-robot
Copy link
Contributor

@arkadeepsen: This pull request references Jira Issue OCPBUGS-37078, which is valid. The bug has been moved to the POST state.

9 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.z) matches configured target version for branch (4.16.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-36750 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent bug Jira Issue OCPBUGS-33750 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-36750 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • dependent Jira Issue OCPBUGS-33750 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR bumps the version of the the DNSNameResolver controller for release-4.16. This PR also adds the additional RBAC permissions required by the CoreDNS pods for the DNSNameResolver CRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@arkadeepsen
Copy link
Member Author

/hold
until openshift/coredns-ocp-dnsnameresolver#13 is merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2024
@melvinjoseph86
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 31, 2024
@arkadeepsen arkadeepsen force-pushed the version-bump-dnsnameresolver-release-4.16 branch from bf788cb to be4080b Compare August 5, 2024 16:57
@arkadeepsen
Copy link
Member Author

openshift/coredns-ocp-dnsnameresolver#13 is now merged
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
@arkadeepsen
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

@arkadeepsen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sdodson sdodson added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Aug 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 7, 2024
Merged
@openshift-merge-bot openshift-merge-bot bot merged commit 8ddf28f into openshift:release-4.16 Aug 7, 2024
10 checks passed
@openshift-ci-robot
Copy link
Contributor

@arkadeepsen: Jira Issue OCPBUGS-37078: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37078 has been moved to the MODIFIED state.

In response to this:

This PR bumps the version of the the DNSNameResolver controller for release-4.16. This PR also adds the additional RBAC permissions required by the CoreDNS pods for the DNSNameResolver CRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-dns-operator
This PR has been included in build ose-cluster-dns-operator-container-v4.16.0-202408070337.p0.g8ddf28f.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.16.0-0.nightly-2024-08-07-052418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melvinjoseph86 melvinjoseph86 Awaiting requested review from melvinjoseph86

@alebedev87 alebedev87 Awaiting requested review from alebedev87

@gcs278 gcs278 Awaiting requested review from gcs278

Assignees

@lihongan lihongan

@melvinjoseph86 melvinjoseph86

@ShudiLi ShudiLi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@arkadeepsen @openshift-ci-robot @melvinjoseph86 @openshift-bot @openshift-merge-robot @sdodson @lihongan @ShudiLi