-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give CoreDNS access to endpointslices #244
Give CoreDNS access to endpointslices #244
Conversation
Allow CoreDNS to read endpointslices. CoreDNS 1.8.1 switched from reading endpoints to reading endpointslices. * assets/dns/cluster-role.yaml: * manifests/0000_70_dns-operator_00-cluster-role.yaml: Allow access to endpointslices. * pkg/manifests/bindata.go: Regenerate.
2f5d14d
to
0b7e10e
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
@Miciah: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
Force merging, these errors are unrelated. |
Allow CoreDNS to read endpointslices. CoreDNS 1.8.1 switched from reading endpoints to reading endpointslices.
assets/dns/cluster-role.yaml
:manifests/0000_70_dns-operator_00-cluster-role.yaml
: Allow access to endpointslices.pkg/manifests/bindata.go
: Regenerate.This change is required because openshift/coredns#52 bumped OpenShift from CoreDNS 1.6.6 to CoreDNS 1.8.1.