Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give CoreDNS access to endpointslices #244

Conversation

Miciah
Copy link
Contributor

@Miciah Miciah commented Mar 6, 2021

Allow CoreDNS to read endpointslices. CoreDNS 1.8.1 switched from reading endpoints to reading endpointslices.

  • assets/dns/cluster-role.yaml:
  • manifests/0000_70_dns-operator_00-cluster-role.yaml: Allow access to endpointslices.
  • pkg/manifests/bindata.go: Regenerate.

This change is required because openshift/coredns#52 bumped OpenShift from CoreDNS 1.6.6 to CoreDNS 1.8.1.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2021
Allow CoreDNS to read endpointslices.  CoreDNS 1.8.1 switched from reading
endpoints to reading endpointslices.

* assets/dns/cluster-role.yaml:
* manifests/0000_70_dns-operator_00-cluster-role.yaml: Allow access to
endpointslices.
* pkg/manifests/bindata.go: Regenerate.
@Miciah Miciah force-pushed the give-CoreDNS-access-to-endpointslices branch from 2f5d14d to 0b7e10e Compare March 6, 2021 21:37
@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Miciah
Copy link
Contributor Author

Miciah commented Mar 7, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2021

@Miciah: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-upgrade 0b7e10e link /test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor

Force merging, these errors are unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants