Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NE-514: Corefile: Drop deprecated kubernetes upstream option #238

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Corefile: Drop deprecated kubernetes upstream option
coredns/coredns#3737 removed the unused
`upstream` kubernetes plugin option from the CoreDNS corefile parser.
Starting in CoreDNS v1.7, corefiles that have the `upstream` option will
throw an error. This change should not affect functionality since the
`upstream` option has been ignored since CoreDNS v1.5. The
aforementioned upstream CoreDNS PR merely requires that the
`upstream` option be removed for the kubernetes plugin section of a
corefile.
sgreene570 committed Feb 24, 2021
commit 742481cc7b48285ade05b25f142642536108936f
1 change: 0 additions & 1 deletion pkg/operator/controller/controller_dns_configmap.go
Original file line number Diff line number Diff line change
@@ -34,7 +34,6 @@ var corefileTemplate = template.Must(template.New("Corefile").Parse(`{{range .Se
health
kubernetes {{.ClusterDomain}} in-addr.arpa ip6.arpa {
pods insecure
upstream
fallthrough in-addr.arpa ip6.arpa
}
prometheus 127.0.0.1:9153
1 change: 0 additions & 1 deletion pkg/operator/controller/controller_dns_configmap_test.go
Original file line number Diff line number Diff line change
@@ -46,7 +46,6 @@ bar.com:5353 example.com:5353 {
health
kubernetes cluster.local in-addr.arpa ip6.arpa {
pods insecure
upstream
fallthrough in-addr.arpa ip6.arpa
}
prometheus 127.0.0.1:9153