NE-514: Corefile: Drop deprecated kubernetes upstream option
#238
Conversation
coredns/coredns#3737 removed the unused `upstream` kubernetes plugin option from the CoreDNS corefile parser. Starting in CoreDNS v1.7, corefiles that have the `upstream` option will throw an error. This change should not affect functionality since the `upstream` option has been ignored since CoreDNS v1.5. The aforementioned upstream CoreDNS PR merely requires that the `upstream` option be removed for the kubernetes plugin section of a corefile.
openshift-ci-robot
added
the
approved
sgreene570
changed the title
upstream optionupstream option
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
coredns/coredns#3737 removed the unused
upstreamkubernetes plugin option from the CoreDNS corefile parser.Starting in CoreDNS v1.7, corefiles that have the
upstreamoption willthrow an error. This change should not affect functionality since the
upstreamoption has been ignored since CoreDNS v1.5. Theaforementioned upstream CoreDNS PR merely requires that the
upstreamoption be removed for the kubernetes plugin section of acorefile.
This PR will unblock openshift/coredns#52 and is therefore a part of https://issues.redhat.com/browse/NE-514.