-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1997396: fix an error with autoscaler alert rules #254
Conversation
the new rules for the resource limits failed to include the time unit for the range vector, this change fixes that.
@elmiko: This pull request references Bugzilla bug 1997396, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@elmiko: This pull request references Bugzilla bug 1997396, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fwiw, i manually ran the entire cluster-api-actuator-pkg against this PR and it worked |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/retest-required |
/retest |
2 similar comments
/retest |
/retest |
we discussed this as a team and feel that it is important enough that we will override the failing tests. i have tested this manually and it is necessary to unblock our failing e2e-aws-operator tests. /override ci/prow/e2e-aws |
@elmiko: Overrode contexts on behalf of elmiko: ci/prow/e2e-aws, ci/prow/e2e-aws-operator, ci/prow/e2e-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@elmiko: All pull requests linked via external trackers have merged: Bugzilla bug 1997396 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@elmiko: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
the new rules for the resource limits failed to include the time unit for the range vector, this change fixes that.