Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1997396: fix an error with autoscaler alert rules #254

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Oct 5, 2022

the new rules for the resource limits failed to include the time unit for the range vector, this change fixes that.

the new rules for the resource limits failed to include the time unit
for the range vector, this change fixes that.
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2022

@elmiko: This pull request references Bugzilla bug 1997396, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1997396: fix an error with autoscaler alert rules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Contributor Author

elmiko commented Oct 5, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2022

@elmiko: This pull request references Bugzilla bug 1997396, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko
Copy link
Contributor Author

elmiko commented Oct 5, 2022

fwiw, i manually ran the entire cluster-api-actuator-pkg against this PR and it worked

@elmiko
Copy link
Contributor Author

elmiko commented Oct 5, 2022

/retest

@Fedosin
Copy link

Fedosin commented Oct 5, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022
@elmiko
Copy link
Contributor Author

elmiko commented Oct 5, 2022

/retest

1 similar comment
@elmiko
Copy link
Contributor Author

elmiko commented Oct 6, 2022

/retest

@JoelSpeed
Copy link
Contributor

/retest-required
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cdc4952 and 2 for PR HEAD 1d97476 in total

@lobziik
Copy link
Contributor

lobziik commented Oct 6, 2022

/retest

2 similar comments
@elmiko
Copy link
Contributor Author

elmiko commented Oct 6, 2022

/retest

@elmiko
Copy link
Contributor Author

elmiko commented Oct 6, 2022

/retest

@elmiko
Copy link
Contributor Author

elmiko commented Oct 6, 2022

we discussed this as a team and feel that it is important enough that we will override the failing tests. i have tested this manually and it is necessary to unblock our failing e2e-aws-operator tests.

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-operator
/override ci/prow/e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

@elmiko: Overrode contexts on behalf of elmiko: ci/prow/e2e-aws, ci/prow/e2e-aws-operator, ci/prow/e2e-upgrade

In response to this:

we discussed this as a team and feel that it is important enough that we will override the failing tests. i have tested this manually and it is necessary to unblock our failing e2e-aws-operator tests.

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-operator
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 6ff627e into openshift:master Oct 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

@elmiko: All pull requests linked via external trackers have merged:

Bugzilla bug 1997396 has been moved to the MODIFIED state.

In response to this:

Bug 1997396: fix an error with autoscaler alert rules

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

@elmiko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elmiko elmiko deleted the fixup-bz1997396 branch October 6, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants