-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1997396: update alerts for resource limits #250
Bug 1997396: update alerts for resource limits #250
Conversation
this will need to wait until we have rebased our autosacler to include the upstream commit mentioned in the description |
@elmiko: This pull request references Bugzilla bug 1997396, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@elmiko: This pull request references Bugzilla bug 1997396, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this change updates the resource limit alerts to use the new metric introduced in kubernetes/autoscaler#5059.
14a6c32
to
7fbde2f
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JoelSpeed one thing i'm not so sure about is the |
@elmiko Do you want to hold this and get QE to validate it before we merge? |
@JoelSpeed yeah, i want to hold until we merge the autoscaler rebase at the least. |
rebase has merged, i an unholding this |
/retest-required |
/override ci/prow/e2e-aws-operator The failed test is known to be broken due to the 1.25 rebase, a fix is up |
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@elmiko: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@elmiko: All pull requests linked via external trackers have merged: Bugzilla bug 1997396 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this change updates the resource limit alerts to use the new metric introduced in kubernetes/autoscaler#5059.