Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1997396: update alerts for resource limits #250

Merged

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Sep 14, 2022

this change updates the resource limit alerts to use the new metric introduced in kubernetes/autoscaler#5059.

@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 14, 2022
@elmiko
Copy link
Contributor Author

elmiko commented Sep 14, 2022

this will need to wait until we have rebased our autosacler to include the upstream commit mentioned in the description
/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

@elmiko: This pull request references Bugzilla bug 1997396, which is invalid:

  • expected the bug to target the "4.12.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1997396: update alerts for resource limits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@openshift-ci openshift-ci bot requested review from enxebre and lobziik September 14, 2022 19:18
@elmiko
Copy link
Contributor Author

elmiko commented Sep 14, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

@elmiko: This pull request references Bugzilla bug 1997396, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 September 14, 2022 19:20
this change updates the resource limit alerts to use the new metric
introduced in kubernetes/autoscaler#5059.
@elmiko elmiko force-pushed the bz1997396-limits-metrics branch from 14a6c32 to 7fbde2f Compare September 14, 2022 19:21
@JoelSpeed
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@elmiko
Copy link
Contributor Author

elmiko commented Sep 15, 2022

@JoelSpeed one thing i'm not so sure about is the for: 15m part of this alert. i think we might need to do some adjusting to get this correct.

@JoelSpeed
Copy link
Contributor

@elmiko Do you want to hold this and get QE to validate it before we merge?

@elmiko
Copy link
Contributor Author

elmiko commented Sep 15, 2022

@JoelSpeed yeah, i want to hold until we merge the autoscaler rebase at the least.

@elmiko
Copy link
Contributor Author

elmiko commented Sep 29, 2022

rebase has merged, i an unholding this
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a733b3f and 2 for PR HEAD 7fbde2f in total

@JoelSpeed
Copy link
Contributor

/retest-required

@JoelSpeed
Copy link
Contributor

/override ci/prow/e2e-aws-operator

The failed test is known to be broken due to the 1.25 rebase, a fix is up

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2022

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-operator

In response to this:

/override ci/prow/e2e-aws-operator

The failed test is known to be broken due to the 1.25 rebase, a fix is up

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2022

@elmiko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d9a9e42 into openshift:master Sep 30, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2022

@elmiko: All pull requests linked via external trackers have merged:

Bugzilla bug 1997396 has been moved to the MODIFIED state.

In response to this:

Bug 1997396: update alerts for resource limits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko elmiko deleted the bz1997396-limits-metrics branch October 11, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants