MGMT-19148: Revert add OLM operator setup jobs finalizing stage (#6933)"

[jhernand]

This reverts commit e4326d4.

The reverted patch added a new finalizing stage that indicates that the assisted installer controller is waiting for OLM setup jobs to complete. But that will not be implemented, so the change is no longer neded.

List all the issues related to this PR

https://issues.redhat.com/browse/MGMT-19148
https://issues.redhat.com/browse/MGMT-19056

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@jhernand: This pull request references MGMT-19148 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

This reverts commit e4326d4.

The reverted patch added a new finalizing stage that indicates that the assisted installer controller is waiting for OLM setup jobs to complete. But that will not be implemented, so the change is no longer neded.

List all the issues related to this PR

https://issues.redhat.com/browse/MGMT-19148
https://issues.redhat.com/browse/MGMT-19056

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jhernand]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.88%. Comparing base (9df3014) to head (5af5345).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7219      +/-   ##
==========================================
- Coverage   67.89%   67.88%   -0.01%     
==========================================
  Files         298      298              
  Lines       40666    40671       +5     
==========================================
  Hits        27609    27609              
- Misses      10587    10589       +2     
- Partials     2470     2473       +3     

Files with missing lines	Coverage Δ
internal/cluster/finalizing_stages.go	89.28% <100.00%> (ø)

... and 3 files with indirect coverage changes

[openshift-ci]

@jhernand: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	5af5345	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[gamli75]

@jhernand Can you check with QE if they have already added this new state to their testing? If yes - they also need to revert their code.

[jhernand]

@jhernand Can you check with QE if they have already added this new state to their testing? If yes - they also need to revert their code.

@gamli75 I checked with the QE team and then confirmed that their code doesn't use this stage.