-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-19148: Add OLM operator setup jobs finalizing stage #6933
MGMT-19148: Add OLM operator setup jobs finalizing stage #6933
Conversation
This patch adds a new finalizing stage that indicates that the assisted installer controller is waiting for OLM setup jobs to complete. Related: https://issues.redhat.com/browse/MGMT-19148 Related: https://issues.redhat.com/browse/MGMT-19056 Signed-off-by: Juan Hernandez <[email protected]>
@jhernand: This pull request references MGMT-19148 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6933 +/- ##
=======================================
Coverage 68.70% 68.71%
=======================================
Files 249 249
Lines 37440 37440
=======================================
+ Hits 25725 25728 +3
+ Misses 9415 9413 -2
+ Partials 2300 2299 -1
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhernand, rccrdpccl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e4326d4
into
openshift:master
@jhernand: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: ose-agent-installer-api-server |
) This patch adds a new finalizing stage that indicates that the assisted installer controller is waiting for OLM setup jobs to complete. Related: https://issues.redhat.com/browse/MGMT-19148 Related: https://issues.redhat.com/browse/MGMT-19056 Signed-off-by: Juan Hernandez <[email protected]>
…shift#6933)" This reverts commit e4326d4. The reverted patch added a new finalizing stage that indicates that the assisted installer controller is waiting for OLM setup jobs to complete. But that will not be implemented, so the change is no longer neded. Related: https://issues.redhat.com/browse/MGMT-19148 Related: https://issues.redhat.com/browse/MGMT-19056
…nshift#6933)" This reverts commit e4326d4.
This patch adds a new finalizing stage that indicates that the assisted installer controller is waiting for OLM setup jobs to complete.
List all the issues related to this PR
https://issues.redhat.com/browse/MGMT-19148
https://issues.redhat.com/browse/MGMT-19056
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist