Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cnf-tests: improve sriov nic selector #1310

Merged
merged 2 commits into from
Nov 24, 2022
Merged

cnf-tests: improve sriov nic selector #1310

merged 2 commits into from
Nov 24, 2022

Conversation

SchSeba
Copy link
Member

@SchSeba SchSeba commented Nov 2, 2022

this commit add a check to be sure for intel nics that we enable sriov in the bios. if that is not the case the totalvf variabel will be 0 so we skip that nic

Signed-off-by: Sebastian Sch [email protected]

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2022
@SchSeba
Copy link
Member Author

SchSeba commented Nov 2, 2022

/hold

need to wait for k8snetworkplumbingwg/sriov-network-operator#373

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2022
@SchSeba
Copy link
Member Author

SchSeba commented Nov 20, 2022

This one can continue new as we did the sriov bump

#1323

@SchSeba
Copy link
Member Author

SchSeba commented Nov 20, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2022
@SchSeba
Copy link
Member Author

SchSeba commented Nov 20, 2022

/retest-required

fedepaol
fedepaol reviewed Nov 23, 2022
View reviewed changes
cnf-tests/testsuites/e2esuite/dpdk/dpdk.go
@@ -709,6 +709,14 @@ func findSriovDeviceForDPDK(sriovInfos *sriovcluster.EnabledNodes, nodeNames []s
if sriovInfos.IsSecureBootEnabled[nodeName] && iface.Vendor == networks.MlxVendorID {
continue
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you wrap this in a "isIntelDisabledNic" function?

@SchSeba SchSeba force-pushed the improve_nic_selection_for_sriov branch from 17f3051 to 062a2e8 Compare November 23, 2022 10:50
@SchSeba
cnf-tests: improve sriov nic selector
86d9412 
this commit add a check to be sure for intel nics that we enable sriov in the bios.
if that is not the case the totalvf variabel will be 0 so we skip that nic

Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba
vendor: bump sriov operator vendor
ce31071 
Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba SchSeba force-pushed the improve_nic_selection_for_sriov branch from 062a2e8 to ce31071 Compare November 23, 2022 10:51
@fedepaol
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2022
@SchSeba
Copy link
Member Author

SchSeba commented Nov 23, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2022 •
edited
Loading

@SchSeba: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ran-profile ce31071 link false /test e2e-gcp-ran-profile

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@SchSeba
Copy link
Member Author

SchSeba commented Nov 24, 2022

both issues are not related to this PR

�[91m�[1mSummarizing 2 Failures:�[0m

�[91m�[1m[Fail] �[0m�[90m[tuningcni] �[0m�[0mtuningcni over macvlan �[0m�[91m�[1m[It] pods with sysctl's over macvlan should be able to ping each other �[0m
�[37m/go/src/github.com/openshift-kni/cnf-features-deploy/cnf-tests/testsuites/e2esuite/security/tuning.go:93�[0m

�[91m�[1m[Fail] �[0m�[90m[rfe_id:27368][performance] �[0m�[0mRPS configuration �[0m�[91m�[1m[It] [test_id:55012] Should have the correct RPS configuration �[0m
�[37m/go/src/github.com/openshift-kni/cnf-features-deploy/vendor/github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/1_performance/performance.go:336�[0m

/override ci/prow/e2e-gcp-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2022

@SchSeba: Overrode contexts on behalf of SchSeba: ci/prow/e2e-gcp-ovn

In response to this:

both issues are not related to this PR

�[91m�[1mSummarizing 2 Failures:�[0m

�[91m�[1m[Fail] �[0m�[90m[tuningcni] �[0m�[0mtuningcni over macvlan �[0m�[91m�[1m[It] pods with sysctl's over macvlan should be able to ping each other �[0m
�[37m/go/src/github.com/openshift-kni/cnf-features-deploy/cnf-tests/testsuites/e2esuite/security/tuning.go:93�[0m

�[91m�[1m[Fail] �[0m�[90m[rfe_id:27368][performance] �[0m�[0mRPS configuration �[0m�[91m�[1m[It] [test_id:55012] Should have the correct RPS configuration �[0m
�[37m/go/src/github.com/openshift-kni/cnf-features-deploy/vendor/github.com/openshift/cluster-node-tuning-operator/test/e2e/performanceprofile/functests/1_performance/performance.go:336�[0m

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 607da7d into openshift-kni:master Nov 24, 2022
@SchSeba
Copy link
Member Author

SchSeba commented Dec 11, 2022

/cherry-pick release-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 11, 2022
Merged
@openshift-cherrypick-robot
Copy link

@SchSeba: new pull request created: #1354

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedepaol fedepaol fedepaol left review comments

@davidvossel davidvossel Awaiting requested review from davidvossel

@nishant-parekh nishant-parekh Awaiting requested review from nishant-parekh

Assignees

@fedepaol fedepaol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SchSeba @fedepaol @openshift-cherrypick-robot @openshift-merge-robot