Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve sriov nic selector in tests #373

Merged
merged 1 commit into from
Nov 15, 2022
Merged

improve sriov nic selector in tests #373

merged 1 commit into from
Nov 15, 2022

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Nov 2, 2022

If the sriov is not able in the kernel for intel nic the totalVF will be 0 so we skip the device. That is not the case for Mellanox devices that will report 0 until we configure the sriov interfaces with the mstconfig package

Signed-off-by: Sebastian Sch [email protected]

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@SchSeba SchSeba mentioned this pull request Nov 2, 2022
Merged
@coveralls
Copy link

coveralls commented Nov 2, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3461104734

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.08%) to 25.123%
Files with Coverage Reduction New Missed Lines %
api/v1/helper.go 3 41.2%
controllers/sriovibnetwork_controller.go 4 65.35%
controllers/sriovnetwork_controller.go 6 65.0%
Totals Coverage Status
Change from base Build 3404779348: -0.08%
Covered Lines: 1884
Relevant Lines: 7499
💛 - Coveralls

adrianchiris
adrianchiris approved these changes Nov 3, 2022
View reviewed changes
test/util/cluster/cluster.go Outdated Show resolved Hide resolved
test/util/cluster/cluster.go Outdated Show resolved Hide resolved
@jjuele
Copy link
Contributor

jjuele commented Nov 7, 2022

Can one of the admins verify this patch?

@SchSeba
improve sriov nic selector in tests
17027e7 
If the sriov is not able in the kernel for intel nic the totalVF will be 0 so we skip the device.
That is not the case for Mellanox devices that will report 0 until we configure the sriov interfaces with the mstconfig package

Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba SchSeba force-pushed the improve_nic_selection branch from 338c734 to 17027e7 Compare November 14, 2022 11:34
@github-actions
Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

e0ne
e0ne approved these changes Nov 14, 2022
View reviewed changes
Copy link
Collaborator

@e0ne e0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SchSeba SchSeba merged commit d3b62b2 into k8snetworkplumbingwg:master Nov 15, 2022
@zeeke zeeke mentioned this pull request Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianchiris adrianchiris adrianchiris approved these changes

@e0ne e0ne e0ne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SchSeba @coveralls @jjuele @e0ne @adrianchiris